I think the easiest thing to do would be to checkout from master all the formatting changes, otherwise a PR would be awesome!
👍. Will do in the am!
Made the pr
I'm very confused. I ran make fmt
before committing both times, and it still fails the check...
Thanks for the PR! When I checkout the PR make fmt
seems to fix the issue. What os are you running?
diff --git a/src/portal/ui/app.cljs b/src/portal/ui/app.cljs
index 11130a5..23a8561 100644
--- a/src/portal/ui/app.cljs
+++ b/src/portal/ui/app.cljs
@@ -155,11 +155,11 @@
viewers (cons default-viewer viewers)
compatible-viewers (filter #(when-let [pred (:predicate %)] (pred value)) viewers)]
{:compatible-viewers compatible-viewers
- :viewer
+ :viewer
(or
- (some #(when (= (:name %) selected-viewer) %)
- compatible-viewers)
- (first compatible-viewers))
+ (some #(when (= (:name %) selected-viewer) %)
+ compatible-viewers)
+ (first compatible-viewers))
:set-viewer!
(fn [viewer]
(set-settings! {:selected-viewer viewer}))}))
You can apply this diff if it doesn't seem to be working locally
I couldn't tell ya what changed, but it appears to have worked this time 🙂. I'm on Ubuntu 18 LTS btw.
1💯Left some comments on the PR
Left a reply & a 2nd commit. Should resolve the issue if I understand it correctly
Looks good! I did notice your example doesn't seem to work.
I think you want the k and not the v in your nav fn