Clojurians Log v2

what do you think about adding the note about this in the Getting Started doc to the with-options docs? I was just about to ask this very question and I happened to see that you’ve already answered it 😄

@schmee It's explained in the Getting Started doc already: > Note: Because get-datasource and get-connection return plain JDBC objects (`javax.sql.DataSource` and java.sql.Connection respectively), next.jdbc/with-options cannot flow options across those calls, so if you are explicitly managing connections or transactions as above, you would need to have local bindings for the wrapped versions:

That's in this section https://cljdoc.org/d/seancorfield/next.jdbc/1.1.588/doc/getting-started#datasources-connections--transactions

I guess I can add a note after the first mention to go read that section below...

@seancorfield yes, I’ve seen the note, what I mean is adding that “note” part to the with-options docstring :thumbsup:

the note explained it perfectly, I just couldn’t find it 😄

Ah, OK. I added this note to Getting Started to link the two sets of examples https://github.com/seancorfield/next-jdbc/commit/ef96e04cb6bc4aa5a187f2f2ac5d21bef646d216

I'll take a look at the docstring and see what I do. I do sort of assume folks read the whole the Getting Started guide before they, you know, get started 🙂

haha, that is certainly a fair assumption, just making a suggestion on behalf of all us speedreaders out there 😁 :thumbsup:

OK, updated the dosctring https://github.com/seancorfield/next-jdbc/commit/0142b25dc6f980c381106dfa5bed1948b35e47b0

sweet, thank you! 🙂