@borkdude: FYI I created this issue on rolling bb support upstream into integrant: https://github.com/weavejester/integrant/issues/86
@borkdude: Some of the integrant tests use clojure.core/find-var
and it looks like that’s not included in bb/sci. Is that supportable?
----- Error --------------------------------------------------------------------
Type: clojure.lang.ExceptionInfo
Message: Could not resolve symbol: find-var
Location: /Users/rick/repos/3rdparty/integrant/test/integrant/core_test.cljc:101:50
Phase: analysis
----- Context ------------------------------------------------------------------
97: (is (= (ig/read-string "{:foo/a #ig/ref :foo/b, :foo/b 1}")
98: {:foo/a (ig/ref :foo/b), :foo/b 1}))
99: (is (= (ig/read-string "{:foo/a #ig/refset :foo/b, :foo/b 1}")
100: {:foo/a (ig/refset :foo/b), :foo/b 1}))
101: (is (= (ig/read-string {:readers {'test/var find-var}}
^--- Could not resolve symbol: find-var
102: "{:foo/a #test/var clojure.core/+}")
103: {:foo/a #'+}))))
104:
105: #?(:clj
106: (defn- remove-lib [lib]
Certainly. It's like resolve but only for vars right?
Yeah I think so
ok, can you post an issue in sci? This is easily supportable
of course :thumbsup:
looks like you already support find
(which find-var
uses)
I think resolve is a better drop-in for this
resolve is implement in sci.impl.namespaces, if you want to take a stab at it
sci has its own implementations of these things
If you have questions/suggestions about sci implementation related things, #sci is also a good channel for that
:thumbsup: Great thanks… I’ll maybe take a look at it later if I have enough energy this evening or later in the week, but for now I need to do some real work…
Issue opened here: https://github.com/borkdude/sci/issues/420
Thanks. I will fix it before the next bb regardless :)
ok no rush from my part btw… I don’t even have a use for bb yet alone integrant+bb 🙂 just figured I’d have a play with it.
compatibility of babashka with existing libs is a nice thing to have
Agreed… there’s a lot of things I can picture myself using sci/bb for; just thought I’d start dipping my toes into the ecosystem a little first. Thanks again for everything! Exciting times!