boot-dev

Boot development discussion and banter
richiardiandrea 2017-12-23T01:27:37.000027Z

Snapshots need manual deletion in .m2 last time I checked and therefore no good. I like the idea of using version modifiers like that, and probably -u should change accordingly.

richiardiandrea 2017-12-23T01:31:06.000008Z

There is a nice package called boot-semver that handles version files pretty well 😉

flyboarder 2017-12-23T01:35:59.000101Z

@martinklepsch can we build and package boot with boot?

richiardiandrea 2017-12-23T01:49:19.000029Z

ah ah

richiardiandrea 2017-12-23T01:49:25.000012Z

I was think about that

richiardiandrea 2017-12-23T01:49:52.000008Z

@flyboarder at the moment it is built with Makefiles

martinklepsch 2017-12-23T11:49:04.000002Z

@richiardiandrea @flyboarder https://github.com/boot-clj/boot/pull/340 has the changes for building boot with boot. Also see the other referenced issue

richiardiandrea 2017-12-23T01:50:21.000052Z

but with your new shiny boot-exec in theory we could use boot to build

flyboarder 2017-12-23T02:09:54.000046Z

“bootception”

martinklepsch 2017-12-23T09:55:35.000061Z

There’s a closed PR somewhere that built boot with boot

martinklepsch 2017-12-23T10:59:54.000051Z

Seems that Maven gives some well known qualifiers special treatment so that boot -u issue might be a non issue https://stackoverflow.com/a/31482463/175920

martinklepsch 2017-12-23T11:03:48.000053Z

I’m assuming Aether/Pomegranate use the same stuff as foundation? Also kind of curious what tools.deps does in this regard

martinklepsch 2017-12-23T11:06:05.000029Z

Ah but I think the boot -u issue is still unclear. Depends on whether releases with -beta or similar are taken into account when specifying “RELEASE”

juhoteperi 2017-12-23T11:08:49.000035Z

RELEASE has some problems, which is why it is rarely used

juhoteperi 2017-12-23T11:10:01.000063Z

Don't remember properly, maybe it was that Maven has to check the repository every time if dependency uses RELEASE version

juhoteperi 2017-12-23T11:10:27.000050Z

SNAPSHOT versions are cached for some duration, not sure about RELEASE

juhoteperi 2017-12-23T11:17:42.000055Z

SLJ4J warning is from pomegranate/maven-resolver

juhoteperi 2017-12-23T11:18:18.000044Z

Will be very hard to fix that unfortunately, we can't automatically add nop/simple logger as that would break projects using real loggers

juhoteperi 2017-12-23T11:18:52.000016Z

Maybe we'll need code to check project deps and only add logger if there isn't one

juhoteperi 2017-12-23T11:19:33.000070Z

Or maybe slf4-api has some method to check if logger is available... and then we can inject logger... if we can do that before it prints the warning, it would probably be most robust solution

juhoteperi 2017-12-23T11:25:50.000009Z

If we can manage to run code before Maven-resolver classes are loaded, we can use java.util.ServiceLoader.load to check for SLF4JServiceProvider and if none is found, add nop/simple logger to classpath

martinklepsch 2017-12-23T11:50:17.000015Z

@juhoteperi Could you open an issue for that?

martinklepsch 2017-12-23T12:34:33.000089Z

@juhoteperi do you know if there’s a re-run button somewhere in AppVeyor?

juhoteperi 2017-12-23T12:35:32.000006Z

"Re-build commit" under the build view

martinklepsch 2017-12-23T12:47:28.000006Z

hm, I don’t think I have that option, maybe only the owner can do it? @juhoteperi

juhoteperi 2017-12-23T12:48:00.000053Z

Hmm, I think AppVeyor permissions should depend on Github because there doesn't seem to be any way to configure them

juhoteperi 2017-12-23T12:48:26.000066Z

Or hmm, it is under by account so it is possible

juhoteperi 2017-12-23T12:50:33.000011Z

@martinklepsch Check now, I found option where I can give permissions based on Github organizations

martinklepsch 2017-12-23T12:51:26.000076Z

hm @juhoteperi it should be on a page like this right? https://ci.appveyor.com/project/Deraen/boot/build/288

juhoteperi 2017-12-23T12:51:45.000010Z

Yeah

juhoteperi 2017-12-23T12:51:54.000031Z

Check again, I tuned the permissions a bit

juhoteperi 2017-12-23T12:52:17.000002Z

And have you logged into appveyor with your github account?

juhoteperi 2017-12-23T12:52:23.000042Z

or connected gh to your account

martinklepsch 2017-12-23T13:09:56.000049Z

yes

martinklepsch 2017-12-23T13:11:53.000043Z

still not there 😄

martinklepsch 2017-12-23T13:12:34.000071Z

This is what I see, page ends with the blue log output box.

juhoteperi 2017-12-23T13:14:59.000072Z

😕

martinklepsch 2017-12-23T14:24:49.000054Z

well, I’ll just force push without edits then. Strange though.

martinklepsch 2017-12-23T17:09:26.000031Z

hey @shimbaco 👋

👋 1