Clojurians Log v2

I don't think it's possible currently. I think this may be best done with a new Calva command. Feel free to file an issue for a feature request.

he, from today I see this error :

no idea if it's a calva issue

I think it should be solved with those command snippets. We recently pulled a PR that adds some editor variables to those snippets. Sounds like if we add variables for the current form and current top level form, we would handle this case. You think so too, @janne.sauvala ?

Anyone testing out the fix for line-comments should be using this VSIX instead of the one above: https://10367-125431277-gh.circle-artifacts.com/0/tmp/artifacts/calva-2.0.154-971-language-configuration-5e4302e3.vsix And if you have used the one above you should uninstall it. This is because the above one uses a release version number. I’m sorry about that, but Circle CI was down yesterday and I missed a step when building the VSIX locally.

can happen

Well, in 2.0.134 ^C will allow the terminal to be reused. In clojure-lsp versions, the termnal does not return to a usable state and has to be closed.

2.0.134 behaviour was:

^C
Terminal will be reused by tasks, press any key to close it.

Yes, that could work. I got the idea from Sean Corfield’s setup with vscode+Clover. And your suggestion could be how Clover handles custom command integration with the editor 👍:skin-tone-2:

In both I see

clj꞉user꞉> 
; Jack-in done.
clj꞉user꞉> 
; nREPL Connection was closed

The terminal does get reused if there is a fresh jack-in, but is unavailable for command entry.

Sounds like it behaves as intended, but is a bit confusing in how it works and communicates. It is a very limited terminal there. It is a pseudoterminal where I have implemented only the minimal amount of input handling (ctrl+c and that’s it). I probably should mimic that behaviour with closing the terminal on any further input.

Although the link is to a vsix, when I download I get a zip file containing many things but not a vsix. Do I just change the extension to vsix? And by the way, is there any harm to keeping the version I downloaded yesterday, which is working well. It did install as 2.0.154, but I'm not sure what the implications of that are.

I didn't know it would download as a zip, but changing file extension should work. No harm in keeping the one you have other than that I am unsure how it will behave when we release the real 154, which probably will contain other changes. But maybe we will find out soon.

ok, no problem. Thanks again!

This is strange, I just looked on another computer and it's showing option-enter. I don't (yet?) understand the difference between these machines. Will look at it at work tomorrow.

@pez Did you see my error. It happens when starting up calva

> Classpath lookup failed in clojure-lsp. Some features may not work correctly. I started seeing it too; it does not show on all projects. Shows with https://github.com/nextjournal/clojure-mode-demo/ for example

It's related with clojure-lsp , where it failed to lookup the classpath, we had some issues with windows users on this, but it was fixed recently

are you using latest Calva version?

look like it I have 2.0.153

@brandon.ringe may help us, the issue we fixed it was this one: https://github.com/clojure-lsp/clojure-lsp/issues/237

oke, I tested it more

and I see it only on 1 project which uses clokure cli

the edn file looks like this :

{:source-paths ["src"]

 :dependencies [[binaryage/devtools "0.9.10"]
                [proto-repl "0.3.1"]
                [reagent "0.8.0"]]

 :nrepl        {:port 3333}

 :builds
 {:app {:target :browser
        :output-dir "public/js"
        :asset-path "/js"

        :modules
        {:main
         {:entries [giggin.core]}}

        :devtools
        {:after-load  giggin.core/main
         :http-root   "public"
         :http-port   3000}}}}

Should I put this project on github so you calva experts can take a look at it

I guess allowing params would make it way more extensible. Also if it seems many users are using the same custom command, maybe it's a candidate for a built-in command.

Yeah and link it on that issue would be super helpful 🙂

Another thing that would be really helpful is looking in /tmp/clojure-lsp.out for the error that occurred during classpath lookup. It should contain "classpath" so you can search for that. If you add that to the issue that would be great.

you mean the issue you linked me too

found the error

java.io.IOException: Cannot run program "shadow-cljs" (in directory "/home/roelof/learn-reagent-course-files/giggin"): error=2, No such file or directory

Yeah, the CircleCI vsix downloads starting coming down as .zip some time ago, and every time I have to change the file extension to .vsix.

wierd. that is package and not a file

It means you need to install the shadow-cljs command line tool

See the shadow-cljs docs for how, but I think it's just a global npm package install

It's trying to run shadow-cljs to get the classpath, but if you don't have it installed, it won't work

@ericdallo Do you think it would be too verbose to add the error message to the warning message sent from the server? It may save some confusion/questions/time

Or even a link (can links be placed in those?) to docs explaining where to find the error and how to fix

Not sure if either are a good idea

links are not supported for all clients so I'd avoid, but if a error message is simple and easy to get, we can add it, but I'd prefer to keep that on clojure-lsp.out and warn user to check that file on the error message, WDYT?

If you look in /tmp/clojure-lsp.out you can see what the error was when it failed. In some cases it means the command line tool clojure-lsp is using to get the classpath is not installed, so the command is not found, like shadow-cljs

Yeah, I think pointing them to that would be good for sure

Have we updated the wiki about this?

I do wonder if the global shadow-cljs is the best way to get the classpath for those projects. Some people may not have it installed but may use npx shadow-cljs or something else. Not sure how else this can be done but if it can be done via clj or lein in conjunction with shadow that might be a more broadly working solution

Another idea is having fallback options for shadow, but this adds complexity that I'm not sure is a good idea. Like try shadow-cljs - if this fails try npx shadow-cljs etc

Just did 😃

I see, there are too many ways indeed, it'd be cool if clojure-lsp would be smart to just make it work , and maybe provide an option/flag to specify the shadow-cljs command, then calva could just make a bridge for that settings too

I don't know too much about shadow-cljs though

hmm, I thought it was installed

but I will do it again

installed it but the error still appearing

Hmm yeah an issue and your repro steps would be great

> " (|)" + backspace = ""; should yield " " (& 2nd backspace to delete the space) A change for calva? Or for my calva-extras?

moment.repro steps? How do you mean that

There are a few more things in how editing behaves inside strings that we should note down in an issue. Please start it off by creating an issue for this.

issue made : https://github.com/BetterThanTomorrow/calva/issues/984

Thanks! I just meant what steps lead up to the error, but what you provided is good

https://github.com/BetterThanTomorrow/calva/issues/985

happy to hear

hope it can be solved soon

if you need more info im happy to give

I just re-read what @pez said and I'm not sure it hit me the first time. That sounds like a great idea. :simple_smile:

OK thanks - I’ll give the latest another go. I’m very glad to see that those pesky clojure-lsp startup messages seem to have disappeared. At first it felt really clunky having to cancel those in every window for no perceivable benefit over clj-kondo.

Any progress on a better workflow for cljs+figwheel-main + webpack jack-in? I did send in a docs PR a while ago explaining my get around for this, but it’s a sub-optimal approach and I think that PR got left behind when you moved the docs github. Those docs are still in https://github.com/gmp26/calva-docs if you want to take another look.

Yeah, it is supposed to give its enhancement without all that shouting. Even if the enhancements are quite huge.

Oh. good that you reminded about it. We will pull in the docs enhancements. Work on the actual jack-in is not really on my schedule right now. But I would welcome an issue about it so that I or someone else can pick it up when we have time and knowledge enough.