calva

Wednesdays you might find @U0ETXRFEW in the Gather Calva space. Invite is https://gather.town/invite?token=GZqrm7CR and the password is `Be kind`.
Cris B 2021-02-09T04:07:37.253600Z

OK https://github.com/BetterThanTomorrow/calva/issues/1023. I'm fairly clueless about how to proceed, but I'll make a bit of time late in the week to investigate.

pez 2021-02-09T12:08:39.253900Z

pez 2021-02-09T12:09:56.254700Z

Attaching the gif here since the shared post doesn’t include it. πŸ˜ƒ

πŸ‘ 4
πŸŽ‰ 4
pez 2021-02-09T14:31:17.255700Z

It is pretty amazing how fast kondo is to report on the issues with reordering the bindings.

clyfe 2021-02-09T14:43:52.256200Z

How do you make these gifs?

clyfe 2021-02-09T14:44:49.256400Z

I want to make one with my backspace positional thing. That may warm some hearts.

pez 2021-02-09T14:58:21.256600Z

I use GIF Brewery. It’s free as in beer. Crashes on me some times, but otherwise is very nice and produces crisp gifs. You can crop it both in time and space. Don’t know if it is available for Linux though

bringe 2021-02-09T18:25:54.257900Z

I use Peek on linux - if that's what you use

🎯 1
bringe 2021-02-09T18:26:20.258300Z

Welcome @jonoflayham!

2021-02-09T18:26:48.258700Z

Thanks! Here because I’m considering leaving IntelliJ…

lread 2021-02-09T18:32:39.261Z

I am enjoying my time with Calva and am astonished by the pace of the Calva team. I think you are at least 8 borks on the borkdude productivity meter!

😁 1
πŸ˜‚ 3
pez 2021-02-09T18:34:57.262900Z

Haha, I think we might be an 8th bork, but that is pretty impressive! πŸ˜ƒ

pez 2021-02-09T18:35:30.263700Z

Super happy for your kind words, @lee. Thanks! ❀️

lread 2021-02-09T18:38:04.266300Z

Hey, personally I rate 0.1 productivity borks on a good day. :simple_smile: I’m happy with it, but am always impressed when I see productive teams!

seancorfield 2021-02-09T18:38:35.267Z

VS Code already updated Calva and I just tried out that new dragging feature: very nice! I don't know if I'll ever be able to remember the key chord for it, mind you πŸ™‚ (but I have the command palette)

pez 2021-02-09T18:39:44.268500Z

Try to remember the shortcuts for dragging forms out of and into lists backward and forward, and then maybe these in-list ones will seem easy. πŸ˜ƒ

lread 2021-02-09T18:41:37.270100Z

As a Calva noob, I am wondering if Calva/lsp looks at my local project clj-kondo hooks. I ask because I am getting warnings in Calva for things my hooks do handle when running clj-kondo from the command line.

bringe 2021-02-09T18:42:19.270400Z

Hm, can you provide a repro case in an issue?

pez 2021-02-09T18:43:29.271500Z

We are all a bit of Calva+lsp noobs, @lee. However, @brandon.ringe and @ericdallo are an amazing team to watch when they are trying to tame this beast.

2
❀️ 2
ericdallo 2021-02-09T18:46:39.274800Z

@lee, clojure-lsp should use your .clj-kondo/config.edn just like if you were using only clj-kondo

lread 2021-02-09T18:48:52.276300Z

Ok, cool. I’m happy to provide a repro in an issue. I’ll start with just linking to my project and describing, and then can isolate more at your request.

lread 2021-02-09T18:49:45.276900Z

Raise in calva or clojure-lsp?

ericdallo 2021-02-09T18:51:10.278200Z

I'd sugges open the issue on Calva, then we could analyze and open on clojure-lsp if it's a bug there πŸ˜‰

clyfe 2021-02-09T19:02:56.280500Z

Backspace positional in calva-extras - powerlevel 80%. (For the rest 20% I need sexp parsing apis.)

lread 2021-02-09T20:07:54.281800Z

Thanks team Calva, https://github.com/BetterThanTomorrow/calva/issues/1026, ignore my mention of clj-kondo hooks here on Slack, think I was on the wrong track there!

πŸ‘ 1
borkdude 2021-02-09T20:11:16.282700Z

You can temporarily disable diagnostics in LSP and use the standalone clj-kondo VSCode plugin

lread 2021-02-09T20:12:40.283300Z

Ah, did not know I could do that, thanks! Will do and update issue.

borkdude 2021-02-09T20:16:06.283600Z

This is what I do in emacs as well, since I usually run a bleeding edge clj-kondo

lread 2021-02-09T20:17:03.284Z

How do I disable diagnostics in LSP?

borkdude 2021-02-09T20:20:18.284500Z

I don't know about Calva but in emacs I set the variable lsp-diagnostics-provider :none

ericdallo 2021-02-09T20:46:34.286700Z

Probably Calva does not support that πŸ˜• but I'd not recommend doing this since the lint on the file reflects on clj-kondo analysis, so your code could show it's correct because of a newer version of clj-kondo or something like that, but clojure-lsp is not being able to parse the code or understands it

borkdude 2021-02-09T20:47:39.287300Z

Of course the underlying problem should be addressed, this is why I said 'temporarily' :)

borkdude 2021-02-09T20:48:10.287800Z

But even if you turn off diagnostics, clojure-lsp should be able to invoke clj-kondo for analysis

1
ericdallo 2021-02-09T20:49:10.288400Z

yes, a temporary flag on Calva could help on thses cases πŸ˜‰

lread 2021-02-09T21:51:00.289500Z

Ok, I shall leave issue as-is then.

borkdude 2021-02-09T22:37:08.290200Z

I double checked and I don't think it's an issue with clj-kondo itself, rather an issue with maybe not picking up the config correctly in lsp / calva (not sure how these are wired up together)

borkdude 2021-02-09T22:40:11.290800Z

Maybe it would help if calva / lsp could display the effective config used somehow

borkdude 2021-02-09T22:40:45.291300Z

You can see this when invoking clj-kondo.core/run! and then pprinting the returned :config

bringe 2021-02-09T22:55:51.292100Z

Related issue here @lee: https://github.com/BetterThanTomorrow/calva/issues/980

bringe 2021-02-09T22:55:59.292500Z

More discussion in the linked PR

ericdallo 2021-02-09T22:57:38.293400Z

Yeah, confirmed the issue is on clojure-lsp side, it's using the home clj-kondo dir instead of the project config πŸ˜•

lread 2021-02-09T22:58:20.294Z

Hey, that was quick, and probably an easy fix! Nice!

ericdallo 2021-02-09T22:59:17.294400Z

🀞 Looking into it right now

1
βœ… 1
ericdallo 2021-02-09T23:00:02.294600Z

Created this issue to track it: https://github.com/clojure-lsp/clojure-lsp/issues/308

1
ericdallo 2021-02-09T23:12:32.295100Z

@borkdude I wondering if clojure-lsp should find the clj-kondo config to pass it via the clj-kondo API

borkdude 2021-02-09T23:13:15.295300Z

clj-kondo already has logic to find its config. why pass it?

ericdallo 2021-02-09T23:13:17.295500Z

Is there any way to pass some configs that we want (like cache, analysis etc) but still make clj-kondo keep the behaviour of find the configs

borkdude 2021-02-09T23:14:39.295700Z

yes, you just pass :config which is a vector of additional configs which will be merged into the config that the user already has in .clj-kondo

ericdallo 2021-02-09T23:15:27.295900Z

oh perfect, I think the issue is that ATM clojure-lsp is merging with a config from .lsp/config.edn (probably leftover after kondo integration πŸ˜…)

ericdallo 2021-02-09T23:15:31.296100Z

will do the test right now

borkdude 2021-02-09T23:35:12.296400Z

πŸ’€ πŸ‘‹

πŸ‘‹ 1