If you do that, and want to somehow migrate it to ClojureScript, I can help :). Also, there's rewrite-cljs
that could help a ClojureScript implementation or even to fix bugs in the current version too.
ok, brilliant. i'm up for that. π
:thinking_face: do we do all of paredit.js @mauricio.szabo?
just unify it
(i'm hoping we can get some graalvm WASM action soon-ish so we can make it crazy fast too)
I'll have to look into paredit.js to see all it does, but maybe :)
@mauricio.szabo Having looked at the CSS a bit, I think you can fix this by removing display: flex
and flex-direction
from the :div.chlorine.console.native-key-bindings
element.
The children will flow in the correct order anyway (since div
s are display: block
by default, and therefore will arrange themselves on the y-axis.)
Flex on the parent + overflow: auto
on the children seems go wonky for some reason.
Alternatively, remove height: 100%
on :div.chlorine.console.native-key-bindings
, and give its parent overflow-y: scroll
Btw, is it possible to set the font-size? 1.3em
is a bit much for me.
morning @mauricio.szabo
i'm looking at the source for repl-tooling. i wouldn't mind getting compliment's docs in on the completion. is that something you've already looked at?
@gerred morning, yes, I would love to get the docs. But please, start from this branch: https://github.com/mauricioszabo/repl-tooling/pull/33
I'm migrating Autocomplete so it would be easier to integrate other tools like cljs-suitable π
π
should I run repl-tooling locally as of now if I'm building myself? π
@henrik great, thanks! I'll look at it. As for the font-size, you can change on your Atom stylesheet. I'll probably change the font size too, because on my Atom setup the size is almost perfect, but I'm seeing inconsistent behaviour depending on the editor
Youβre right. As I can see, it seems to come from .atom/packages/atom-ide-ui/modules/atom-ide-ui/pkg/atom-ide-console/styles/console.less
Oh, thanks for catching this up! I'll look at it, probably the Atom IDE UI overrides some styles π
@henrik I really want to thank you for the time tracking this! Indeed, the atom-ide-ui
package overrides .console
selector. The thing is, the fix I was thinking would not work because of CSS resolve rules, so I need to be more specific on the selector π.
No problem @mauricio.szabo, happy I could help π
@gerred clone the project, npm install
, npx shadow-cljs watch integration
, then on another tab, npm start
It'll open an "electron app" with devcards, so you can test your behavior there, do tests, etc...
OH NICE.
thank you.
Aha, gotcha!
Hey, I'm trying your fixes, but I'm not setting display: flex
on div.chlorine.console
Did you fix by adding display: block
on devtools?
Also, I saw that I can't remove height: 100%
from console because it messes up the auto-scroll π
Great, any problem ping me π
Really, maybe something else is providing it. Iβll have a closer look. But yeah, if you set display: block
, it should override other peopleβs opinions.
That's strange, on a blank slate Atom on Linux the display: flex comes from the atom-text-editor
, but it is overwrites by some other CSS.
I'll publish a new version with this fix, and some refactorings I'm working right now