chlorine-clover

About Chlorine for Atom and Clover for VS Code: https://atom.io/packages/chlorine and https://marketplace.visualstudio.com/items?itemName=mauricioszabo.clover
mauricio.szabo 2019-09-17T01:04:08.050500Z

If you do that, and want to somehow migrate it to ClojureScript, I can help :). Also, there's rewrite-cljs that could help a ClojureScript implementation or even to fix bugs in the current version too.

2019-09-17T01:05:33.050700Z

ok, brilliant. i'm up for that. πŸ™‚

2019-09-17T01:49:46.050900Z

:thinking_face: do we do all of paredit.js @mauricio.szabo?

2019-09-17T01:49:51.051100Z

just unify it

2019-09-17T01:50:16.051300Z

(i'm hoping we can get some graalvm WASM action soon-ish so we can make it crazy fast too)

mauricio.szabo 2019-09-17T02:58:45.051500Z

I'll have to look into paredit.js to see all it does, but maybe :)

henrik 2019-09-17T07:24:24.054Z

@mauricio.szabo Having looked at the CSS a bit, I think you can fix this by removing display: flex and flex-direction from the :div.chlorine.console.native-key-bindings element. The children will flow in the correct order anyway (since divs are display: block by default, and therefore will arrange themselves on the y-axis.)

henrik 2019-09-17T07:25:37.054500Z

Flex on the parent + overflow: auto on the children seems go wonky for some reason.

henrik 2019-09-17T07:31:19.055300Z

Alternatively, remove height: 100% on :div.chlorine.console.native-key-bindings, and give its parent overflow-y: scroll

henrik 2019-09-17T07:33:12.055900Z

Btw, is it possible to set the font-size? 1.3em is a bit much for me.

2019-09-17T10:44:38.056100Z

morning @mauricio.szabo

2019-09-17T10:45:53.056700Z

i'm looking at the source for repl-tooling. i wouldn't mind getting compliment's docs in on the completion. is that something you've already looked at?

mauricio.szabo 2019-09-17T13:23:56.057500Z

@gerred morning, yes, I would love to get the docs. But please, start from this branch: https://github.com/mauricioszabo/repl-tooling/pull/33

mauricio.szabo 2019-09-17T13:24:18.058200Z

I'm migrating Autocomplete so it would be easier to integrate other tools like cljs-suitable πŸ™‚

2019-09-17T13:24:35.058600Z

πŸ‘

2019-09-17T13:24:46.059Z

should I run repl-tooling locally as of now if I'm building myself? πŸ˜„

mauricio.szabo 2019-09-17T13:26:35.060600Z

@henrik great, thanks! I'll look at it. As for the font-size, you can change on your Atom stylesheet. I'll probably change the font size too, because on my Atom setup the size is almost perfect, but I'm seeing inconsistent behaviour depending on the editor

henrik 2019-09-18T09:10:46.065900Z

You’re right. As I can see, it seems to come from .atom/packages/atom-ide-ui/modules/atom-ide-ui/pkg/atom-ide-console/styles/console.less

mauricio.szabo 2019-09-18T16:10:18.066100Z

Oh, thanks for catching this up! I'll look at it, probably the Atom IDE UI overrides some styles πŸ™‚

mauricio.szabo 2019-09-18T17:39:36.066300Z

@henrik I really want to thank you for the time tracking this! Indeed, the atom-ide-ui package overrides .console selector. The thing is, the fix I was thinking would not work because of CSS resolve rules, so I need to be more specific on the selector πŸ™‚.

henrik 2019-09-19T02:17:15.070800Z

No problem @mauricio.szabo, happy I could help πŸ™‚

mauricio.szabo 2019-09-17T13:27:35.061800Z

@gerred clone the project, npm install, npx shadow-cljs watch integration, then on another tab, npm start It'll open an "electron app" with devcards, so you can test your behavior there, do tests, etc...

2019-09-17T13:28:13.062Z

OH NICE.

2019-09-17T13:28:15.062200Z

thank you.

henrik 2019-09-17T13:28:46.062300Z

Aha, gotcha!

mauricio.szabo 2019-09-17T13:51:15.062500Z

Hey, I'm trying your fixes, but I'm not setting display: flex on div.chlorine.console Did you fix by adding display: block on devtools?

mauricio.szabo 2019-09-17T13:51:55.062700Z

Also, I saw that I can't remove height: 100% from console because it messes up the auto-scroll 😞

mauricio.szabo 2019-09-17T13:52:12.062900Z

Great, any problem ping me πŸ™‚

henrik 2019-09-17T15:25:37.065300Z

Really, maybe something else is providing it. I’ll have a closer look. But yeah, if you set display: block, it should override other people’s opinions.

mauricio.szabo 2019-09-17T15:32:18.065500Z

That's strange, on a blank slate Atom on Linux the display: flex comes from the atom-text-editor, but it is overwrites by some other CSS. I'll publish a new version with this fix, and some refactorings I'm working right now