chlorine-clover

About Chlorine for Atom and Clover for VS Code: https://atom.io/packages/chlorine and https://marketplace.visualstudio.com/items?itemName=mauricioszabo.clover
seancorfield 2020-01-22T01:08:16.008500Z

@mauricio.szabo Found a breakage. It looks like the run tests command no longer writes its output to the console. The popup still appears with the summary of the results, but the success/failure messages do not appear in the console.

mauricio.szabo 2020-01-22T02:20:33.011600Z

Thanks, I think I know which part of the code broke that. I'll test tomorrow to see if I can find the error :)

seancorfield 2020-01-22T03:06:18.012500Z

I had a quick look myself but couldn't figure out why doc-for-var still works but the two run test commands don't (well, they "work", they just don't produce stdout 🙂 )

seancorfield 2020-01-22T03:06:45.012800Z

I've gone back to 0.3.9 for now.

mloughlin 2020-01-22T09:45:07.014300Z

a minor issue, but my Chlorine REPL always seems to stop auto-scrolling to bottom. Any idea if I've missed a config setting?

mloughlin 2020-01-22T09:45:41.015Z

I'm assuming it'd be an Atom window option, if anything, but nothing jumps out at me...

mauricio.szabo 2020-01-22T13:38:00.016300Z

@michael.e.loughlin it always auto-scroll to the bottom, or only when it's already scrolled? For example, if it auto-scrolls, if you scroll a little bit up and evaluates something, it still auto-scrolls?

mauricio.szabo 2020-01-23T13:30:44.000200Z

Well, this is an unknown issue 🙂. I'll see if I can debug it here

mloughlin 2020-01-23T13:35:34.000400Z

Thanks for taking a look. Don't worry too hard about it, it's not a huge deal!

mauricio.szabo 2020-01-22T13:57:08.017300Z

This is the issue: https://github.com/mauricioszabo/repl-tooling/compare/cda108417818ce8e28f5f6013a0abaacb0efafe9...6640a8ade0d1aad0fb6a2f770e567074a0907bf6 I need to wait a little for the REPL to be ready before redirecting the console (for some reason, the test output does not go to *out* by default)

mloughlin 2020-01-22T14:27:48.017400Z

it loses the auto scroll after I scroll up a bit

mauricio.szabo 2020-01-22T14:28:22.017600Z

Well, this is the "default" behavior. Do you think it needs to change? Like, some config variable, or something?

mloughlin 2020-01-22T14:28:55.017800Z

it would be nice if it was possible to return to auto-scroll mode 🙂

seancorfield 2020-01-22T18:05:37.018500Z

@mauricio.szabo I saw the commit for 0.4.1 -- but it's not yet available, right? Is other stuff going into that release?

seancorfield 2020-01-22T18:06:41.019500Z

(I don't mean to sound impatient -- more "wow, quick fix!" and I'll reiterate my support and praise for your amazing work as I live and die in Atom/Chlorine/REBL all day, every day!)

mauricio.szabo 2020-01-22T18:08:04.021100Z

No problem. Nothing new is going to go for the 0.4.1, but somehow the CI broke... and it seems that indeeed, something is broken 😞 I'm debugging to publish a new version 🙂

seancorfield 2020-01-22T18:09:53.022100Z

Cool. I'm on vacation today so if I end up doing Clojure today, it'll be "only" my OSS projects 🙂

mauricio.szabo 2020-01-22T18:41:36.023900Z

This is the error: https://github.com/mauricioszabo/repl-tooling/pull/54/files To be honest, I'm not completely sure what's happening. A ClojureScript command should never return because it literally blocks the REPL. Somehow, it is returning nil, but I'm going to change this code soon, and I have another self-check to see if the REPL was upgraded correctly

mauricio.szabo 2020-01-22T21:22:30.025900Z

@seancorfield just published version 0.4.1, fixing the issue with test output! 🎉 Now you can reiterate the support, and also add that there's code quality control that will not allow to ship bugs to production 😆

1
mauricio.szabo 2020-01-22T21:26:32.026Z

Ah, got it. I was missing the point. So, when you scroll up a bit, it stops auto-scrolling, even if you scroll all the way back to the bottom?

mauricio.szabo 2020-01-22T21:26:50.026200Z

Also, are you on Linux, Windows, Mac? Any changes on screen DPI or something?

seancorfield 2020-01-22T21:31:14.026900Z

Thanks. Will check it out when I get back from the vet.

mauricio.szabo 2020-01-22T21:32:42.028Z

I made some tests here on my side, it seems that this bug is fixed. Please let me know if you find other issues.

mloughlin 2020-01-22T22:36:20.028100Z

I was describing it terribly! Yeah, it doesn't seem to resume auto-scrolling when I scroll to the bottom. I'm on Windows 10, I'll double check the screen DPI & so on when I'm next on my dev machine

mloughlin 2020-01-22T22:36:42.028300Z

it's not changing, but I am using a lot of "swap desktop" win + ctrl + left/right arrow