chlorine-clover

About Chlorine for Atom and Clover for VS Code: https://atom.io/packages/chlorine and https://marketplace.visualstudio.com/items?itemName=mauricioszabo.clover
fabrao 2020-04-15T02:56:14.222Z

so, Iยดll try to create some script to start it up inside init.coffee

seancorfield 2020-04-15T17:59:43.222700Z

@mauricio.szabo I updated to Chlorine 0.5.2 and go-to-var is broken (macOS).

mauricio.szabo 2020-04-15T18:00:32.223Z

Ok, let me see what's wrong...

seancorfield 2020-04-15T18:04:18.223600Z

Downgraded to 0.5.1 and it works just fine. Let me know if/how I can assist with debugging.

mauricio.szabo 2020-04-15T18:11:49.224200Z

Does something appears on the Atom devtools console, for example?

seancorfield 2020-04-15T18:17:38.225300Z

How/where do I see that? The symptom is that it ends up opening an empty file with the same name as where the definition would be, so this feels like the path is broken.

mauricio.szabo 2020-04-15T18:18:59.226900Z

Right, so it does open something, but its an empty file without anything on it... Can you click on the filename on Atom, and see if the full path is correct? I think Atom will copy the full path to clipboard

seancorfield 2020-04-15T18:20:45.227800Z

It looks like it's removing the leading / on the file path and concatenating it with the project root. Which suggests the fix for Windows has broken macOS.

seancorfield 2020-04-15T18:21:42.228700Z

How can I debug what os.platform() is returning?

mauricio.szabo 2020-04-15T18:21:43.228800Z

Yes, it seems so. While you're on the devtools (I think its the command "Window: Toggle Dev Tools"), can you evaluate a command?

seancorfield 2020-04-15T18:21:55.229Z

Yup, what should I run?

mauricio.szabo 2020-04-15T18:22:18.229300Z

require('os').platform()

seancorfield 2020-04-15T18:22:59.229500Z

darwin ๐Ÿ™‚

seancorfield 2020-04-15T18:23:19.230Z

Which matches win in your norm-result function.

mauricio.szabo 2020-04-15T18:23:22.230100Z

OMG...

mauricio.szabo 2020-04-15T18:24:07.231100Z

Yes, I'll fix this ๐Ÿ˜„. I don't believe it. I kept with win only because Node sends win32 for windows, even when it's a 64-bit machine, so I imagined that future versions could break it ๐Ÿ˜„

mauricio.szabo 2020-04-15T18:26:44.231600Z

Will publish a new version ๐Ÿ™‚

mauricio.szabo 2020-04-15T18:35:06.231800Z

Just waiting for the CI: https://github.com/mauricioszabo/atom-chlorine/pull/169

seancorfield 2020-04-15T18:36:09.232500Z

I wonder if #"^win" would be safer?

seancorfield 2020-04-15T18:37:04.232800Z

According to the Node.js docs: "Possible values are 'aix', 'darwin', 'freebsd', 'linux', 'openbsd', 'sunos', and 'win32'."

mauricio.szabo 2020-04-15T18:37:22.233100Z

Yes, I missed the case for darwin

mauricio.szabo 2020-04-15T18:37:50.233900Z

I think I'll keep at #"^win\d+"

seancorfield 2020-04-15T18:38:03.234200Z

(but, yeah, it's weird that it returns win32 on 64-bit systems... I assume because Node itself is only 32 bit and doesn't have a 64-bit version?)

mauricio.szabo 2020-04-15T18:39:05.234900Z

Not really... on node's download page, it does list 32 and 64-bit versions

seancorfield 2020-04-15T18:39:24.235300Z

Even weirder. But... Node... ๐Ÿ™‚

seancorfield 2020-04-15T18:40:34.235800Z

Thanks for the quick fix. I'll keep mashing the "Check for updates" button until it appears ๐Ÿ™‚

mauricio.szabo 2020-04-15T18:51:49.236100Z

Just published ๐Ÿ™‚

seancorfield 2020-04-15T18:55:05.236400Z

Confirmed fixed!! โค๏ธ

mauricio.szabo 2020-04-15T18:58:04.236700Z

Thanks! โค๏ธ

fabrao 2020-04-15T23:00:42.237500Z

@mauricio.szabo In Windows still ok !!!

1