Clojurians Log v2

can we cut a release? I think the :exists performance is blocking us right now (still running tests, tho).

I wanted to test the SNAPSHOT and realized I have to install an older JDK to compile the project. In particular, :javac-options ["-target" "1.6" "-source" "1.6"] is no longer supported. Does anyone know that best version to build with? (It isn’t enough to just change those to “1.8” … that brings up a ClassNotFoundException: javax.xml.bind.DatatypeConverter issue, which I think is JDK11 [LTS] and higher.)

On mac, I do JAVA_HOME=$(/usr/libexec/java_home -v 1.8) lein install or what not.

That just worked for me today.

The target options are only about bytecode, iirc.

The xml thing is common in libs that haven’t upgrade some deps yet

Clara has some lower version deps right now, it should be changed with some better profiles I think

but you can work around the jdk11 things I think with just adding to the module path

in :jvm-opts add "--add-modules java.xml.bind"

can do that in your ~/.lein/profiles.clj or just alter Clara’s project

oh, there is already a profile for this in clara

lein with-profile java9 install

you can build with a bit higher cljs/clj too with a profile built-in

lein with-profile java9,recent-clj install

However, the java9 is slightly misleading, I think it should work with jdk11 too (pending any not testing jdk11 issues with clara or lib it uses)

I do not see this though :javac-options ["-target" "1.6" "-source" "1.6"] and that doesn’t seem ideal to me

I think Clara should remove that, maybe a good PR…

maybe just do this: lein update-in : assoc :javac-opts "^:replace []" -- with-profile java9, recent-clj install - hah, quite rough

@eraserhd Regarding cutting a release in the near future, that seems reasonable to me - any objections anyone? Probably 0.19.1 looking at the changelog.

We likely need to make a profile to build for more modern things and make that the default dev setup. Can have separate install/deploy configuration and testing

@wparker release seems fine to me based on what I see

and minor version seems acceptable - nothing in there should be breaking or considered a “feature add”

Agreed