Clojurians Log v2

hi @borkdude 🙂 do you know if anyone has a reagent.core/with-let linter, that shows you unused bindings?

@robert-stuttaford I think you can just use :lint-as + clojure.core/let for that

ok that simple, nice

turns out we are...

but it doesn't work?

no 😞

it does correctly warn that symbols are not defined when used on the right side of the binding, but it doesn't warn that bindings in the form are unused

@robert-stuttaford This warns that x is unused for me:

(ns foo
  {:clj-kondo/config '{:lint-as {reagent.core/with-let clojure.core/let}}}
  (:require [reagent.core :refer [with-let]]))

(with-let [x 1]
  (fn []))

ok, i'll dig and see if i can figure out what's going on, thank you!

might be related to your config for defcomp

which is probably a custom macro

lol :unused-binding {:level :off} in config.edn is prrrrrrobably why

there's a comment citing this issue https://github.com/borkdude/clj-kondo/issues/885 which is now fixed yay

ok it works, false alarm, sorry for the noise

np :) btw, you use both Rum and Reagent?

i'm helping a different team out with some stuff 🙂