clj-kondo

https://github.com/clj-kondo/clj-kondo
avocade 2020-10-19T13:14:04.197100Z

Any idea how to silence the linter errors for the naked (action [] …) and (remote [] …) definitions inside fulcro's defmutation macro? 🙂

borkdude 2020-10-19T13:15:15.197700Z

@avocade you can always put a #_:clj-kondo/ignore on it, if you can't solve it any other way. I'm not familiar with those macros

borkdude 2020-10-19T13:15:32.198Z

you might want to write a hook for the defmutation macro though

1👍
borkdude 2020-10-19T13:16:28.198600Z

Also see https://github.com/borkdude/clj-kondo/blob/master/doc/config.md

jaihindhreddy 2020-10-19T15:12:40.199500Z

Is a PR welcome for https://github.com/borkdude/clj-kondo/issues/1042?

borkdude 2020-10-19T15:13:24.200100Z

@jaihindhreddy yes please - are you also using that in format?

jaihindhreddy 2020-10-19T15:13:52.200600Z

Nope. The mere existence of false-positives bugs me for some reason 😅

jaihindhreddy 2020-10-19T15:14:17.201100Z

I did use relative indexing once for some online puzzle (before clj-kondo, a while ago)

borkdude 2020-10-19T15:14:52.201300Z

PR welcome :)

1💯
jaihindhreddy 2020-10-19T15:26:03.202Z

https://github.com/borkdude/clj-kondo/pull/1045. (The checks ran successfully.)

borkdude 2020-10-19T15:37:12.203300Z

@jaihindhreddy I think we might as well just do (.charAt ^String s 1) instead of nth, since we know it's a string and don't need the polymorphic behavior which just wastes CPU cycles

jaihindhreddy 2020-10-19T15:38:17.204400Z

Yeah, considered it, and thought it might be a premature optimisation. In retrospect, the string is created within the function, and I'm just wasting CPU with nth. Changing.

jaihindhreddy 2020-10-19T15:40:19.205100Z

done

borkdude 2020-10-19T15:41:50.205300Z

Thanks!

jaihindhreddy 2020-10-19T15:44:02.206100Z

https://github.com/borkdude/clj-kondo/issues/378 seems like a false flag. Perhaps it can be closed.

borkdude 2020-10-19T15:46:21.206400Z

responded in issue

1💯