clj-kondo

https://github.com/clj-kondo/clj-kondo
richiardiandrea 2021-03-22T16:02:18.114800Z

Hi there, say I have with-db-transaction called this way jdbc/with-db-transaction [tx (:spec db) {:isolation :repeatable-read}] - how would I go in linting it so that it detects the last option map?

richiardiandrea 2021-03-22T16:06:33.114900Z

I see this PR here https://github.com/clj-kondo/clj-kondo/pull/823/files I am checking if I can use it as well (using clojure.java.jdbc)

richiardiandrea 2021-03-22T16:10:25.115100Z

ok never mind, it turns out I had a {clojure.java.jdbc/with-db-transaction clojure.core/let} and the above is built in so I just removed it

borkdude 2021-03-22T16:13:38.115300Z

Does the current implementation of these macro analyzers not cover all usages?

richiardiandrea 2021-03-22T16:17:02.115600Z

it does - see my above answer, I had miss-configured my config.edn

richiardiandrea 2021-03-22T16:17:13.115800Z

thanks for checking in 😉

helios 2021-03-22T17:13:30.116700Z

In this blogpost about our bootstrapped CI i show how we directly tap into Clj-kondo from a notebook for our CI linting https://nextjournal.com/blog/ci

borkdude 2021-03-22T17:19:30.117400Z

@helios Nice incremental approach. > This is not something that couldn't have been achieved with a traditional CI and a bit of Bash scripting Since you are bringing up bash: also possible using babashka and the clj-kondo pod btw hehe

👍 1
borkdude 2021-03-22T17:20:19.118100Z

But if you are running a JVM for testing anyway, yeah, why not run clj-kondo as part of it :)

borkdude 2021-03-22T17:35:03.118700Z

@helios Maybe worth adding a link in ci-integration.md about this article

👍 1