clj-kondo

https://github.com/clj-kondo/clj-kondo
robert-stuttaford 2021-06-13T06:35:14.227600Z

it looks like with :skip-comments true at the project level, and :skip-comments false at the namespace level, unused requires doesn't see the usages inside comment forms in our dev/*.clj repl scripts, and continues to warn about unused namespaces when they are actually used inside the comments. (we skip comments on the project level as we have a pre-commit hook to prevent committing anything with linter warnings or errors) when i set false at the project level, it does see them, and stop warning about unused requires. by no means a showstopper, just wondering if this is something that is simple to fix, or inherent to the way the usage analysis is working?

borkdude 2021-06-13T08:22:51.227700Z

I can reproduce the issue locally.

robert-stuttaford 2021-06-13T08:47:27.227900Z

ok, so it's not just me 😄 thank you @borkdude!

borkdude 2021-06-14T10:11:08.232500Z

@robert-stuttaford Fixed on master. You could use a versioned snapshot version if you are using clj-kondo on the JVM in CI.

borkdude 2021-06-14T10:11:43.232700Z

What I mean is: > Sending clj-kondo/clj-kondo/2021.06.02-SNAPSHOT/clj-kondo-2021.06.02-20210614.101046-4.jar (309k)

borkdude 2021-06-14T10:11:56.232900Z

you could use the "2021.06.02-20210614.101046-4" part as the version

robert-stuttaford 2021-06-14T10:21:37.233100Z

thank you @borkdude!

borkdude 2021-06-13T08:22:51.227700Z

I can reproduce the issue locally.

robert-stuttaford 2021-06-13T08:47:27.227900Z

ok, so it's not just me 😄 thank you @borkdude!