Released a binary now: https://github.com/borkdude/deps.clj/releases/tag/v0.0.2 https://github.com/borkdude/deps.clj#windows
I guess this can function as a Graal POC. Let me know what you think.
I think I'm almost there 🙂 https://github.com/littleli/scoop-clojure/pull/14
@borkdude Wow, very nice. Does exactly what it says on the tin, for Windows cmd
!
The set CLOJURE_TEST_CP=...
thing doesn't seem to work in Powershell, but works fine in cmd
.
yeah, I only tested this from cmd.exe
I'm going to merge it. I cannot test this though. I'm far away from my windows box.
it's CLOJURE_TOOLS_CP
btw, not TEST
Yeah, my typo. I got it right in Windows. Just typed it wrong here because I was thinking about "testing" stuff 🙂
thought so 🙂 I'm afk now, got way too late
hopefully scoop install deps.clj`` I'm afraid little bit about the
.
It works. Just tested it.
Very well, thanks Sean
@borkdude I installed it on another Windows machine and when I try to run deps
I get an error that MSVCR100.dll is missing -- and so far none of the things I've tried to fix that from the web have worked. If anyone here has some more suggestions, I'm all ears. (it's the Microsoft Visual C++ Redistributable DLL in case folks don't know -- but installing various versions from Microsoft's sites hasn't fixed this error) Success! I found a new page that had direct downloads of that DLL and after putting it in Windows\system32, deps
worked just fine!
I should probably put Microsoft Visual C++ 2010 x64 Redistributable to scoop recommendations. I believe it could be installed with scoop as well.
Good idea
I'm now adding functionality to download the clojure tools jar when it isn't found yet. So then there's no need to download any zip files yourself.
Released! https://github.com/borkdude/deps.clj/releases/tag/v0.0.3
Added the scoop to the README now
Should be this one https://github.com/lukesampson/scoop-extras/blob/master/bucket/vcredist2010.json
I'll add issue to scoop-clojure repository, it should eventually happen
Cool. I made a note in the README as well.
https://github.com/littleli/scoop-clojure/issues/17 I'll take a look later
I added suggest section to scoop manifest for clj-kondo
and deps.clj
I would like to kindly ask for confirmation that I didn't break anything. @seancorfield
It'll be tonight at the earliest before I can test that. Well try to remember after work.
I'll also try in a virtual machine
@seancorfield might be good to document what your problem was and what the solution was: Windows version, dll version and source
Here I read: > It turns out that msvcr100.dll from VS C++ Redistributable 2010 must be present or the application will fail to start. Maybe installing VS C++ Redistributable 2010 would have helped @seancorfield? Might be good to try
The message is reproducable when I uninstall the C++ redistributable. Then when I install https://www.microsoft.com/en-us/download/details.aspx?id=14632 again, it works. I'll add that to the README.
Perfect, thanks for the confirmation :)
Just to make sure, this applies to all the binaries created with native-image right?
Think so yes
wasn't there an oracle/graal issue along these lines? may be if it doesn't have this info already it would be worth adding.
here is something that seems related: https://github.com/oracle/graal/issues/1762
here is another: https://github.com/oracle/graal/issues/1407
@ales.najmann I installed deps.clj 0.0.3
using your scoop:
Installing 'deps.clj' (0.0.3) [64bit]
deps.clj-0.0.3-windows-amd64.zip (2.6 MB) [===================================================================] 100%
Checking hash of deps.clj-0.0.3-windows-amd64.zip ... ok.
Extracting deps.clj-0.0.3-windows-amd64.zip ... done.
Linking ~\scoop\apps\deps.clj\current => ~\scoop\apps\deps.clj\0.0.3
Creating shim for 'deps'.
'deps.clj' (0.0.3) was installed successfully!
'deps.clj' suggests installing 'extras/vcredist2010'.
'itcode"' is not recognized as an internal or external command,
operable program or batch file.
After this, calling deps
works fine:
C:\Users\borkdude>deps -Sdescribe
{:deps-clj-version "0.0.3"
:version "1.10.1.492"
:config-files ["C:\\Users\\borkdude\\.clojure\\deps.edn"]
:config-user "C:\\Users\\borkdude\\.clojure\\deps.edn"
:config-project "deps.edn"
:install-dir nil
:cache-dir "C:\\Users\\borkdude\\.clojure\\.cpcache"
:force ""
:repro ""
:resolve-aliases ""
:classpath-aliases ""
:jvm-aliases ""
:main-aliases ""
:all-aliases ""}
C:\Users\borkdude>
Not sure what this means: > 'itcode"' is not recognized as an internal or external command, operable program or batch file.
Installing clj-kondo also worked, with the same suggestion and without the itcode
message.
you're using cmd.exe
right?
I don't know what above issue means. But there is similar report here https://github.com/lukesampson/scoop/issues/1935
yeah
I now uninstalled it and installed it again, now I don't get the message.
So you can probably ignore this.
I put an issue with "won't fix" label to my project and I'll take a look later, if there is a way to improve installation from cmd.exe
note that the installation worked, in spite of this message
Sure. I won't burn time on it 🙂