made some significant progress getting cljdoc responsive today π
Hey @ichigo π
hi everyone, hi @martinklepsch, i've watched your talk on ClojureTRE, good project well done :thumbsup: , i want this project to get my first open source contribution π, i'm kind of beginner so i won't be of that help, but i'll start navigating the code and hopefully i can help someday
yeah thanks, i've seen that issue, so if i understand it right, the "more recent version" notification should not appear in case of the newer releases are just Snapshots, right ?
i think i need to know the shape of the cache bundle
map passed to the cljdoc.bundle.more-recent-version
function
@ichigo here's how :latest
gets into the cache bundle: https://github.com/cljdoc/cljdoc/pull/168/files#diff-a9925a94dd89b08dad3afbe0a721dc30R118
In general that diff will be useful for a bit more context
@martinklepsch i'm sorry for being so beginner here π³ , so we need to not put the snapshots in the db at first place i guess
but that looks out of the scope of that issue
No worries π I think it might be easiest to just filter the list of versions to remove any versions ending with -SNAPSHOT before taking the last version in the line I linked to.
Hope that makes sense.
It might be helpful to just get the project running and experiment with the get-documented-versions
function at the REPL
If youβre having trouble setting up a REPL with your editor (which is very handy) I can help you tomorrow or you can ask for help in #editors or #beginners
Good luck! π (and good Night for now :)
hhhh thank you, i'm running the repl now, but yeah i need to use it from inside emacs
yeah that the first thing i thought about the -SNAPSHOT
part, but because i'm like a stranger in a new town hhhh i'm too doubtful
thank you, good night for you too :simple_smile:
Sounds great @ichigo β welcome to the crew! π
If you want I can point you to some easy first issues that you could try to work on to get familiar with the project setup etc.
thank you, yes please i would like to try
So this would be a pretty easy and actually pretty valueable thing to fix: https://github.com/cljdoc/cljdoc/issues/203
To get up and running this document should be helpful: https://github.com/cljdoc/cljdoc/blob/master/doc/running-cljdoc-locally.md
OMG I just git reset --hard
a few hours of work π€¦ Was able to recover most of it via open Emacs buffers but wow. Don't code at night kids! π
On the other hand the responsiveness stuff I got done today is amazing β¨ if I may humbly say so