cljdoc

https://cljdoc.org/ & https://github.com/cljdoc/cljdoc
2018-11-19T03:30:01.151300Z

The “page not found” page needs to have the message “Page not found” written on the top, otherwise it does not look like the user arrived there via a broken link. At the moment, it looks like a legit search page.

martinklepsch 2018-11-19T09:55:50.151700Z

Fair point, I'll try to fix this later

2018-11-19T16:00:39.152100Z

@martinklepsch are you working on this already? If not I can also fix it.

martinklepsch 2018-11-19T16:01:03.152300Z

Working on other stuff still so feel free 🙂

2018-11-19T16:01:19.152500Z

Ok cool I'm on it

2018-11-19T16:25:54.152700Z

I submitted the PR https://github.com/cljdoc/cljdoc/pull/218. Though the 404 page could be further improved (e.g. adding a link to the home page) this PR has the explicit “404 - Page Not Found” message on the top.

👍 1
2018-11-19T16:29:36.154300Z

@martinklepsch I’d like to learn more about the frontend. I found this one seems to be a good start: https://github.com/cljdoc/cljdoc/issues/99. What do you think?

martinklepsch 2018-11-19T16:30:44.154800Z

Sure, that's a good one

martinklepsch 2018-11-19T20:42:34.156Z

@vincent.cantin @dawran6 your PRs are deployed, thanks again for contributing 🙂

🙌 2