Clojurians Log v2
Clojure programming
Channels
Apps
cljdoc
https://cljdoc.org/ & https://github.com/cljdoc/cljdoc
martinklepsch 2019-01-31T14:51:16.063700Z
I’ve done some work on opening up what types of articles can be supported and would appreciate some feedback on the approach: https://github.com/cljdoc/cljdoc/pull/262
Avichal 2019-02-01T19:27:57.063900Z
@martinklepsch Looks good to me. Just a bit worried about (require ns) in system.clj for external namespaces. But since everything will run in CircleCI I don’t think we need to worry about it?
martinklepsch 2019-02-01T19:39:56.064100Z
What makes you worried about this?
martinklepsch 2019-02-01T19:40:32.064300Z
Are you thinking about security or more that the Clojure runtime will crash for some reason?
Avichal 2019-02-01T19:45:11.064500Z
yes, I was initially thinking about security. But can it crash at runtime?
martinklepsch 2019-02-01T19:46:14.064700Z
Ok, so I think with security we should be good because that option can only be provided via the configuration file when running the process. There's no way to change it from the outside
martinklepsch 2019-02-01T19:46:29.064900Z
And it can crash if some namespace doesn't compile etc.
martinklepsch 2019-02-01T19:46:38.065100Z
The usual reasons I guess
martinklepsch 2019-02-01T19:47:12.065300Z
but we'll notice that as soon as the cljdoc server starts so it should be quite apparent and actually nomad won't promote the release if it doesn't become healthy after a while
Avichal 2019-02-01T19:47:52.065500Z
got it. Sounds good then 👍