Clojurians Log v2

hey ya’ll. really impressed with cljdoc. having some issues with a lib I’d like to have on here

😄

I literally just saw the failing build 🙂

😅

it’s a CLJS lib that depends on React

would it help to provide externs?

Unfortunately I don't have a good answer to this problem currently. cljdoc's analysis builds on the jar/pom only.

I could maybe include cljsjs/react. I’d prefer to allow the consumer to include React however they see fit

Maybe there's a way we can tell the CLJS analyzer to silently ignore string requires, I think that should work (those always refer to npm stuff right?)

yeah, AFAIK

I'll start a thread in #cljs-dev

Hope somebody gets what I'm trying to say 😄

I can try and help clarify if people have questions

I wonder how shadow-cljs does the analysis

It looks at node_modules and creates some input for the analyzer based on that.

But we don't know what node_modules should look like since we only look at the pom.xml

In a sense a library like clinch doesn't perfectly declare it's dependencies because react is sort of coming out of another package manager

Would be interesting to see how this problem could be solved in general but I guess it hasn't been too much of an issue so far

@martinklepsch I created an example not too long ago that showed how to deal with string requires easily. I can't remember where I put it though.

I posted it here and you asked me to create a PR which I forgot 😛

Now that you say it this rings a bell! I’ll try do look that up in the logs next weekend after Clojure/north. @lilactown if you want to open an issue against cljdoc that would be great, then we can’t forget (as I apparently did before :D)

👍 Done!