cljdoc

https://cljdoc.org/ & https://github.com/cljdoc/cljdoc
martinklepsch 2019-04-23T00:49:17.037600Z

Hey @nick.matthewsβ€” I've sent @devth a message about this: [...] for Yetibot I think the issue might be that some thread pools are started in the background. There seems to be some dirigiste / manifold stuff β€” if you want to look into it I'd suggest you look out for that kind of stuff To test stuff you can clone this repo: https://github.com/cljdoc/codox/tree/cljs-proper/codox make sure you check out the cljs-proper branch and then run clj -Sdeps '{:deps {yetibot {:mvn/version "0.5.18"}}}' -m codox.main clojure yetibot-0.5.18.jar with a version that you've installed into your local maven

martinklepsch 2019-04-23T00:49:56.038Z

Happy to help with this but wanted to wait of Trevor has some ideas where those threads might be coming from

martinklepsch 2019-04-23T00:54:58.038700Z

@seancorfield fyi you can also link to the latest version with a much shorter link like this: https://cljdoc.org/d/seancorfield/next.jdbc

martinklepsch 2019-04-23T00:55:14.039300Z

This will automatically redirect to the first article at the latest RELEASE version

seancorfield 2019-04-23T02:01:03.039800Z

Yeah, but that doesn't show up in the browser address bar for easy copy'n'pasting πŸ™‚

martinklepsch 2019-04-23T03:06:27.040300Z

That's true, just wanted to mention it in case the long links bothered you πŸ˜„

martinklepsch 2019-04-23T03:35:06.040600Z

I dug a bit more into this and found a bug that's now fixed in production. Tested it with these changes to the next.jdbc repo: https://github.com/seancorfield/next-jdbc/compare/master...martinklepsch:cljdoc-fixes?expand=1

martinklepsch 2019-04-23T03:35:18.040800Z

they're not complete but hopefully helpful enough

martinklepsch 2019-04-23T03:35:53.041Z

In general that "if a link works on github it should work on cljdoc" thing is true and if it isn't, that's a bug πŸ™‚

seancorfield 2019-04-23T03:40:11.041200Z

Nice! Thank you for such a swift fix!

seancorfield 2019-04-23T03:46:49.041400Z

I've done a full regex find'n'replace to fix them all for the next release (rather than take the partial PR). I have more documentation to write (the whole datafy/`nav`/`:schema` thing needs its own page). And, of course, I can only update all the docs when I make a new release πŸ™‚ Alpha 9 contained one tiny bug fix -- and a lot of documentation updates. Alpha 10 will probably be similar, depending on when (if? πŸ™‚ ) I find the next bug!

martinklepsch 2019-04-23T03:57:55.041600Z

sounds great!

martinklepsch 2019-04-23T04:00:38.041800Z

Note that you can also build docs locally for previewing: https://github.com/cljdoc/cljdoc/blob/master/doc/running-cljdoc-locally.md#importing-a-project-from-local-sources

martinklepsch 2019-04-23T04:01:36.042100Z

and (unrelatedly) that you can use [[with-transaction]] to link to other vars in docstrings like this one: https://cljdoc.org/d/seancorfield/next.jdbc/1.0.0-alpha7/api/next.jdbc#transact

martinklepsch 2019-04-23T04:02:03.042400Z

(for other namespaces the sym needs to be fully qualified)

seancorfield 2019-04-23T04:12:59.042600Z

Yeah, I haven't started using WikiLinks in docstrings yet. That's on my list, now that I have cljdoc mostly under my belt πŸ™‚

seancorfield 2019-04-23T04:13:20.042800Z

And good to know re: local building... I will check that out tomorrow!

seancorfield 2019-04-23T20:26:10.044100Z

@martinklepsch Why does this URL show the Alpha 9 readme? https://cljdoc.org/d/seancorfield/next.jdbc/1.0.0-alpha5/doc/readme - it doesn't! But the readme includes badges that are dynamic and therefore confusingly show the current version 😐

seancorfield 2019-04-23T20:31:11.046100Z

I guess I'll have to add text to the README to make that less confusing... Does anyone run into this? Or have suggestions to make it less confusing?

martinklepsch 2019-04-23T20:48:09.047800Z

Happy to consider ideas to make this less confusing - we can do whatever with the articles. We could just remove the badge if it’s there but not sure if that’s such a great idea

dominicm 2019-04-23T20:50:38.048300Z

ifdef::env-github[]
image::<http://cljdoc.org/badge.png|cljdoc.org/badge.png>
endif::[]

martinklepsch 2019-04-23T21:07:29.048900Z

Oh right, Asciidoc already has a solution

dominicm 2019-04-23T21:14:52.049400Z

The natural solution is always to rewrite everything in adoc

polymeris 2019-04-23T21:15:22.050Z

would it be less confusing if the badge just said "cljdoc" without the version number?

martinklepsch 2019-04-23T21:15:54.050400Z

right that may also be an option, given that it generally links to the latest version anyways

seancorfield 2019-04-23T21:23:43.052Z

For now, I changed my README to say

The latest versions on Clojars and on cljdoc:

&lt;&lt;badges go here&gt;&gt;

This documentation is for 1.0.0-alpha9.
Since I do a find&replace for the version number everywhere in the project before I build each release, this will work for now (well, whenever I get around to cutting the next release it will start working on cljdoc πŸ™‚ )

martinklepsch 2019-04-23T21:24:45.053500Z

cool πŸ™‚ asciidoc is pretty nice on cljdoc as well, just FYI: https://cljdoc.org/d/nrepl/nrepl/0.6.0/doc/usage/server

seancorfield 2019-04-23T21:24:46.053600Z

But it's fairly common for project READMEs to contain the Clojars badge (and possibly other version-specific dynamic badges) so I think some sort of rewriting is going to be needed ...

seancorfield 2019-04-23T21:25:21.054200Z

Does GitHub know how to render a README written in AsciiDoc?

martinklepsch 2019-04-23T21:25:25.054400Z

sure

martinklepsch 2019-04-23T21:25:56.055100Z

just click the github link in the top right corner of the nrepl docs and you can see what that looks like (or the edit on github link at the end of the page I linked)

seancorfield 2019-04-23T21:26:25.055600Z

OK, maybe I will do that then (it'll make me learn it at long last πŸ™‚ )

seancorfield 2019-04-23T21:26:34.055800Z

Oh, and the badge thing... https://cljdoc.org/d/nrepl/nrepl/0.5.3/doc/readme

seancorfield 2019-04-23T21:32:26.056300Z

nREPL's README is markdown, not adoc, BTW.

πŸ™ˆ 1
martinklepsch 2019-04-23T22:18:00.057Z

The callouts with tips, warnings and all that are super nice