Clojurians Log v2

oh I won’t go that far.

just do the garamond clojure call

though part of the pom is generated earlier

but that should be good enough

so if I do clojure -A:garamond I should get a pom.xml?

yes

I am getting an error.

Warning: lein-git-version git exited 128
{:exit 128, :out "", :err "fatal: No names found, cannot describe anything.\n"}

19-07-15 00:01:19 LeeMac.local ERROR [garamond.main:120] - nil
                    clojure.main.main     main.java:   40
                                  ...
                    clojure.main/main      main.clj:  616
                    clojure.main/main      main.clj:  664
                clojure.main/main-opt      main.clj:  514
                   clojure.core/apply      core.clj:  665
                                  ...
                  garamond.main/-main      main.clj:   80
                  garamond.main/-main      main.clj:   81
               garamond.main/-main/fn      main.clj:   83
          garamond.git/current-status       git.clj:   39
              clojure.core/re-matches      core.clj: 4886
              clojure.core/re-matcher      core.clj: 4856
      java.util.regex.Pattern.matcher  Pattern.java: 1093
       java.util.regex.Matcher.<init>  Matcher.java:  229
        java.util.regex.Matcher.reset  Matcher.java:  309
java.util.regex.Matcher.getTextLength  Matcher.java: 1283
java.lang.NullPointerException:

hum

"works here" tm =)

you have the .git directory ?

yup just did a simple clone

garamond uses the tags in your repository

hum

what's this lein-git-version thing you have there

there is no lein in this project !

your point is well taken. :simple_smile:

I do not see any tags, I have the right project? https://github.com/cark/cark.behavior-tree

oh looks like my tags are not pushed ? I don't know if that's normal or not

you can generate some with `clojure -A:release patch' ...though this might try to push to github

i'm new to all this

how do people doing open source work manage versions and the like ... I4ve been trying to use what i found, but it's all pretty arcane

I don’t think I am helping you much, but you did introduce me to garamond, so thanks for that. :simple_smile:

good =)

try git push --tags

there you go, the whole sad history of my attempts to make it work has been pushed

don’t forget the joy in the journey :simple_smile:

yes =)

ok, garamond worked after that

ah i knew it !

now to confirgure magit to push those tags automatically ><

looks like that is not recommended, do it one by one is the way to go

I am frankly just learning about deploying with deps.edn proj today! I am testing your project locally now… please hold.

do you think a project should have the tests enclosed with the clojar jar, or leave those on github ?

worked locally here.

but…

no expound problems.

but I created my jar differently than you.

and had to add something to your pom.xml

oh

the suspense is killing me

I know, stay tuned, and you’ll get the full answer tomorrow.

haha

sorry

when testing locally, I do a mvn install which simply reads the pom.xml and install to my local ~/.m2 repo.

yes... i somehow misplaced my mvn command so i didn't test that

and that didn’t work, it created a jar with no source, so I adjusted the pom.xml build section to:

<build>
    <sourceDirectory>src/main</sourceDirectory>
    <resources>
        <resource>
            <directory>src/main</directory>
        </resource>
    </resources>
  </build>

so the resource directory

or resources

mhh ok i can accept that, but this cannot be the problem

I think we should look at when ended up on clojars

i use clojure -A:jar to create the jar

and what get uploaded by your deploy step?

and the jar on clojar has the source code, as it's erroring in the hiccup namespace

the jar i created is uploaded

I see 2 jars create by -A:jar

it only creates one here

I’m doing something very similar to you today. I did not need to create a jar.

how do you upload to clojars ?

mvn deploy

so maven builds the jar and deploys it

ya

I got my inspiration from https://github.com/lambdaisland/kaocha/blob/master/bin/release

your technique might be valid, but it is not the one I used today.

does your jar file contain the pom.xml ?

because mine doesn't

the kaocha way the pom.xml gets tracked in github

mhh

yeah, the pom.xml is under META-INF for me.

ok that might be a good lead

though i don't understand how circleci picks up changes for my clojure dependency but not expound

I don’t know what is going on there. The error might be misleading.

ok thanks i'll try to make it work with maven and maybe simplify the whole process

It is working for me. Though garamond still looks interesting to me.

the goal was to never ever have to manually edit the pom.xml

Yes, and kaocha stuff does not seem to after initial version.

but see i have a strange bug where blank lines are inserted in my pom.xml, so i opted to recreate it every time

probably another windows thing =)

so you’d start with clojure -Spom add the missing bits manually and automate from there.

oh maybe.

probably maven can do it all perfectly, i'll dive into that, thanks for the leads !

but i saw something related to that on kaocha…

maybe this line : https://github.com/lambdaisland/kaocha/blob/123ea05e83adf40d5cea683005b1a30ad1026091/bin/prep_release#L39

ah there you go

i'll end up with a gigabyte pom =)

where kaocha used sed, you can probably use garamond

i think garamond does it too

looks like an underlying bug

that rolls off the tongue nicely: gigabyte pom

from the jvm

oh right

gotta run for now… my lady is waiting.

won't roll off my hard drive as nicely =)

thanks for the help !

hope I did not lead you astray

need to learn maven properly anyways

building with maven (and i guess having the pom.xml in the jar) fixed my troubles

Hey 👋 just read your conversation - if you got things to work with mvn but not with Garamond could you open an issue with instructions how to build pom & jar with each in your project? 🙂

@lee if you’re open to this idea we could also move the cljdoc-exerciser into the cljdoc GitHub org

@martinklepsch, I am guessing that the mvn/garamond conversation was probably not related to any cljdoc issues.

@martinklepsch I would be happy to transfer cljdoc exerciser to cljdoc. I’ll create a separate git issue for it.

ok, well you looked into it the most so if you’re think there’s nothing to do on the cljdoc end then fine 🙂

👍 I’ve definitely wanted to have a testbed project like this before so thanks for making it a thing 🙂

Ok, I raised a handful of cljdoc issues: https://github.com/cljdoc/cljdoc/issues/created_by/lread

Am happy so submit PRs, but some will need a bit of discussion.

@martinklepsch in thsi project, garamond wasn't involved in the actual building, it was only used as a fancy command line to edit the pom.xml

@lee thanks for the lead yesterday =)

my pleasure @carkh