Clojurians Log v2
Clojure programming
Channels
Apps
cljdoc
https://cljdoc.org/ & https://github.com/cljdoc/cljdoc
martinklepsch 2019-10-29T09:41:43.041700Z
@holyjak just taking a final look at the /versions PR — this isn’t needed anymore is it? https://github.com/cljdoc/cljdoc/pull/357/files#diff-7ac04933e500c3f3e36d5bba2a7932faR78
martinklepsch 2019-10-29T09:41:59.041800Z
ah nevermind
martinklepsch 2019-10-29T09:44:40.042Z
@holyjak I’m thinking maybe we just drop that body interceptor and instead of putting stuff into the ::releases key we just put it into :response {:body releases :status 200}
martinklepsch 2019-10-29T09:45:23.042200Z
in the ::releases-loader that is
martinklepsch 2019-10-29T09:45:42.042400Z
I’m happy to make that change but wanted to check how you feel about it
Jakub Holý 2019-10-29T10:45:08.042700Z
You mean essentially mergin what body + body-fn do directly into ::releases-loader interceptor? Why not. Please do it!
martinklepsch 2019-10-29T11:32:49.043Z
yeah pretty much
martinklepsch 2019-10-29T11:33:08.043200Z
since it’s only used once it feels like maybe not worth committing to the helper yet
Jakub Holý 2019-10-29T11:38:05.043400Z
Ok. Please change it as you see fit and merge. Thank you!