Clojurians Log v2
Clojure programming
Channels
Apps
cljdoc
https://cljdoc.org/ & https://github.com/cljdoc/cljdoc
Helins 2020-05-03T23:26:51.044Z
Hi, I don't know if this is "serious" enough to open an issue, maybe I am doing something wrong. My build is failing because of this spec:
clojure.lang.ExceptionInfo: Spec assertion failed
{:publics ()} - failed: (contains? % :name) in: [:analysis "cljs" 1 0] at: [:analysis 1] spec: :cljdoc.analysis/namespace
{:author "Adam Helinski", :publics ()} - failed: (contains? % :name) in: [:analysis "cljs" 1 1] at: [:analysis 1] spec: :cljdoc.analysis/namespace
seancorfield 2020-05-03T23:28:55.044300Z
@adam678 Link to the project in question?
seancorfield 2020-05-03T23:31:28.044800Z
I assume it's this https://github.com/dvlopt/dsim.cljc/blob/master/src/dvlopt/dsim.cljc (or at least, one of the namespaces in that project)?
Helins 2020-05-04T12:21:15.045Z
Hi Sean, no it's dvlopt/fdat: https://cljdoc.org/builds/29873
I reckon I did add a conditional reader in (:require) on cljs.analyzer.api but it shouldn't make a difference. And the package works fine.
https://github.com/dvlopt/fdat.cljc/blob/develop/src/dvlopt/fdat.cljc
seancorfield 2020-05-04T17:12:45.045300Z
Ah, so for the cljs case, you end up with (:require) which is illegal.
seancorfield 2020-05-04T17:13:21.045500Z
That's not a http://cljdoc.org problem, as far as I know, that's just ClojureScript rejecting your code.
seancorfield 2020-05-04T17:14:03.045700Z
(if cljs accepts that, I'd be surprised -- but it certainly doesn't look valid to me)
Helins 2020-05-04T18:38:39.045900Z
Right, I see how that could be a problem. I added the second reader without thinking about it. However, it works! That is why I didn't get alarmed and didn't notice the obvious. Nonetheless I'll change it