Clojurians Log v2

Thanks so much for reviewing! I will have a look shortly! 🙂

My pleasure, looks really great overall

Thanks again for your thoughtful review, I’ve gone over all of your comments. Please feel free to close (or we can discuss further) the ones I have left open.

Approved 🙂

Sweet! GitHub “Rebase and merge” is not possible due to conflicts… is that odd or normal? “Merge pull request” is available though.

If you don’t mind please rebase locally and then merge using “Merge pull request”

IMHO that’s the best way to merge PRs since it doesn’t create interleaving histories and you still have a clear merge commit / branching point

Sounds good, tx, will do.

ok merged! Hope you didn’t mean to imply I should squash, ’cause I did no squashing!

Nope, having the commits is perfect :)

Thank you 🙏

And thank you @martinklepsch! A pleasant and fruitful interaction, as usual! :simple_smile:

Absolutely ☺️ in fact I told a friend about how friendly and pleasant open source can be sometimes :)

I find the Clojure community to be smart, kind, patient and thoughtful. A real nice group!