Clojurians Log v2
cljdoc
Hi @martinklepsch! I have learned that #fulcro has experienced quite a few issues with Cljdoc such as 👇 I have browsed through the GH issues but do not see anything that would seem relevant, weirdly. Is for example this one a known issue? And are there some know limitations to cljs support? Thanks! (I love both Cljdoc and Fulcro so it would be great if they could work together.)
I have opened https://github.com/cljdoc/cljdoc/issues/432
Interesting! If you folks don’t figure this out I’ll take a peek, but it might not be for a bit because I am trying to focus on rewrite-cljc at the moment.
Thanks for checking in and yeah, definitely happy to help with this as much as I can. Could you point me to the source file for this? One issue I immediately think of is that if the file is a cljc file #js is basically invalid syntax
We could could probably add a data reader to support #js
Even if some files are invalid we don’t necessarily care about guaranteeing correctness or something like that
I think that was the point - yes, #js is invalid in clj, therefore there is added a custom reader to make it acceptable also in clj. The file and line: https://github.com/fulcrologic/fulcro/blob/4da887d934d8f9c8a225f3b972a375d634a18138/src/main/com/fulcrologic/fulcro/components.cljc#L845
I’d be open to do something like that for cljdoc 👍
Don’t have a pointer where that would be done from the top of my head but maybe @lee has a pointer :)
But maybe there’s also a way to properly pick up data_readers from analysed projects