cljdoc

https://cljdoc.org/ & https://github.com/cljdoc/cljdoc
2021-05-24T16:34:02.006100Z

Today I put up this PR, which includes the code change needed to fix this issue. I still haven't updated the tests for it yet, but it's a start. https://github.com/cljdoc/cljdoc-analyzer/pull/40

🙌 2
2021-05-24T19:01:20.006800Z

So with this PR now merged, how long should I have to wait before I can rebuild the documentation for farolero?

lread 2021-05-24T19:11:22.010100Z

Congrats @suskeyhose! Someone just needs to update cljdoc to point to your change in cljdoc-analyzer. Technically I think you have the power, but this is your first commit, so we shall help. @martinklepsch I see you merged @suskeyhose’s cljdoc-analyzer change, are you in progress in making it live? If you are busy, lemme know and I can do.

2021-05-24T19:15:03.010300Z

Alright, that makes sense.

martinklepsch 2021-05-24T19:24:19.011300Z

I’m not in front of my computer right now but could do it tomorrow:)

lread 2021-05-24T19:42:23.012100Z

I can do now… I’ll test local and then push. Letcha know when done.

2021-05-24T19:42:59.012300Z

Thanks!

lread 2021-05-24T20:17:40.013500Z

Am experiencing what seem to be local technical difficulties in testing (I don’t think there is anything wrong with your change). Will ping back.

2021-05-24T20:20:43.013700Z

Thanks for the heads up

lread 2021-05-24T20:31:46.014800Z

The technical problem was squarely between my ears. Have pushed change to cljdoc and it should automatically deploy after build/test.

2021-05-24T20:32:13.015100Z

Awesome, thanks for the quick turnaround on this!

lread 2021-05-24T20:33:21.015900Z

Happened to be available, so happy to help.

lread 2021-05-24T20:38:41.016400Z

Ok your change is live!

lread 2021-05-24T20:39:42.016900Z

Feel free to hit the hidden rebuild link to force a rebuild of your docs.

2021-05-24T20:42:11.017200Z

Thanks! It worked like a charm. 🙂

lread 2021-05-24T20:43:07.017800Z

Awesome, thanks for the fix!

2021-05-24T20:50:43.018900Z

No problem! I hope to contribute more in future if I see any more issues.

lread 2021-05-24T21:02:03.019100Z

That’s great! Welcome aboard!