cljs-dev

ClojureScript compiler & std lib dev, https://clojurescript.org/community/dev
dnolen 2019-07-15T15:38:27.342700Z

@borkdude sure

borkdude 2019-07-15T16:11:19.343100Z

ok, I'll have a look this week. gotta find out when exactly it was deprecated 🙂

borkdude 2019-07-15T16:16:54.344400Z

e.g. the replicate docstring was updated to deprecated with this commit: https://github.com/clojure/clojurescript/commit/8d33dd4e55cc87c205bb5c37d0234af6e2132388 24 April 2016. But I bet the function was considered deprecated before that. Maybe I'll just add ^:deprecated instead of :deprecated "1.x.xx"?

alexmiller 2019-07-15T16:40:00.344900Z

that would make the value true, which seems weird given that :deprecated values are normally strings

2019-07-15T16:42:21.345500Z

Given how long ago it was, perhaps just pick the first release version after the commit date, and call it deprecated since then?

borkdude 2019-07-15T16:48:32.346Z

@alexmiller I've seen ^:deprecated before

borkdude 2019-07-15T16:53:31.346800Z

The docstring was probably just copied from Clojure. (cc @mfikes)

borkdude 2019-07-15T16:55:00.347200Z

but if there are no objections, I'll go with @andy.fingerhut's suggestion and add 1.8.51 there

alexmiller 2019-07-15T17:20:59.347800Z

I guess if it’s truthy that’s the main thing