cljs-dev

ClojureScript compiler & std lib dev, https://clojurescript.org/community/dev
dnolen 2019-09-14T16:42:02.000400Z

@mfikes fixed the above issues with the goog var support

mfikes 2019-09-14T16:45:34.001500Z

Cool. One outstanding one is https://clojure.atlassian.net/projects/CLJS/issues/CLJS-3168 That might be trivial to fix; I’ll take a look at it.

dnolen 2019-09-14T16:47:35.002Z

oh yeah I can fix that

mfikes 2019-09-14T16:47:40.002200Z

I think I like the name :js-fn-var… it matches the notion I had in mind, but couldn’t think of a good name for it. 🙂

mfikes 2019-09-14T16:47:58.002600Z

Cool, yeah, probably just a conditional around the use of the externs ns

dnolen 2019-09-14T16:51:01.002800Z

fixed

mfikes 2019-09-14T16:53:54.003300Z

There are a couple of other minor issues I noticed. Logging them https://clojure.atlassian.net/browse/CLJS-3169

mfikes 2019-09-14T16:54:14.003800Z

No big deal for that one, of course… just capturing anything strange I can find.

mfikes 2019-09-14T16:57:08.004300Z

Hrm. I thought I saw parameters missing from doc output on some fns. Maybe that was fixed… will track that down.

dnolen 2019-09-14T17:03:02.005100Z

@mfikes thanks, yeah in goog.string those are control characters - need to think about that

mfikes 2019-09-14T17:03:25.005600Z

Cool, yeah, there are funky var names like " etc. Maybe the same cruft.

mfikes 2019-09-14T17:04:25.006400Z

I’m now thinking the missing parameter name issue was probably me, and they’ve been there all along.