@mfikes fixed the above issues with the goog var support
Cool. One outstanding one is https://clojure.atlassian.net/projects/CLJS/issues/CLJS-3168 That might be trivial to fix; I’ll take a look at it.
oh yeah I can fix that
I think I like the name :js-fn-var
… it matches the notion I had in mind, but couldn’t think of a good name for it. 🙂
Cool, yeah, probably just a conditional around the use of the externs
ns
fixed
There are a couple of other minor issues I noticed. Logging them https://clojure.atlassian.net/browse/CLJS-3169
No big deal for that one, of course… just capturing anything strange I can find.
Hrm. I thought I saw parameters missing from doc
output on some fns. Maybe that was fixed… will track that down.
@mfikes thanks, yeah in goog.string those are control characters - need to think about that
Cool, yeah, there are funky var names like "
etc. Maybe the same cruft.
I’m now thinking the missing parameter name issue was probably me, and they’ve been there all along.