cljs-dev

ClojureScript compiler & std lib dev, https://clojurescript.org/community/dev
thheller 2019-10-11T09:59:55.002200Z

@mfikes can you kick off another closure-library release? the latest closure-compiler isn't compatible with the older versions anymore since they changed goog.define and the older use is now an error.

mfikes 2019-10-11T11:16:35.002600Z

That may require @dnolen (I don’t have permissions)

thheller 2019-10-11T11:23:48.003100Z

oh ok. thought you did the other intermediate release last time

dnolen 2019-10-11T12:06:13.003300Z

I can look at that today

thheller 2019-10-11T14:44:57.003900Z

@dnolen this is the change I was refering to https://github.com/google/closure-compiler/commit/447052cfe2803cb4c1a67a36b622dc1d670642e8

thheller 2019-10-11T14:45:38.004800Z

basically it is an error now to use goog.define("goog.DEBUG", true) and must now be used as goog.DEBUG = goog.define("goog.DEBUG", true) (needs the assignment)

thheller 2019-10-11T14:45:57.005100Z

was going to put together a patch for goog-define as well