cljs-dev

ClojureScript compiler & std lib dev, https://clojurescript.org/community/dev
dnolen 2019-10-29T00:00:58.056100Z

@filipematossilva thanks! did you already submit a CA?

Filipe Silva 2019-10-29T12:00:15.065700Z

I submitted one about 6 months ago, is that still in effect?

Filipe Silva 2019-10-29T12:01:48.066Z

Yes, I can confirm I have email confirmation saying "Clojure CA between Rich Hickey and Filipe Silva is Signed and Filed!" from June 3

dnolen 2019-10-29T17:29:09.072400Z

k great, thanks

Filipe Silva 2019-10-30T20:20:30.076600Z

Now I that it's live I see I broke the anchor format (it can't have spaces). I'm sorry for that. https://github.com/clojure/clojurescript-site/pull/329 shows the problem and fixes it.

kommen 2019-10-29T07:40:30.057100Z

while at it, 2 recent doc enhancements from me: https://github.com/clojure/clojurescript-site/pull/327 https://github.com/clojure/clojurescript-site/pull/326

2019-10-29T07:52:29.058Z

👋 and this one from me: https://github.com/clojure/clojurescript-site/pull/324

mkvlr 2019-10-29T08:09:45.061600Z

we’re seeing js file with syntax errors generated recently, without having changed the clojurescript version. We’re doing more js interop e.g. via set!. An example of an error would be a missing namespace, e.g. .autocompleter_choice = (function …) where com.nextjournal.editor.article.gutter_actions.autocompleter_choice = (function …) would be correct. Anybody else notice something like this?

mkvlr 2019-10-29T08:10:40.062300Z

we do have :parallel-build true set

thheller 2019-10-29T08:14:08.063100Z

@mkvlr this is likely related to on inference bug that was fixed in master. can't quite remember the details but it was causing incorrect code like that

mkvlr 2019-10-29T08:14:51.063700Z

@thheller ok, we’ll try updating to latest master and see if that helps, thanks!

mkvlr 2019-10-29T08:17:41.064300Z

and it could still be non-deterministic in that case?

mkvlr 2019-10-29T08:18:38.064900Z

ah, and we’re using a version with that patch included

thheller 2019-10-29T08:20:13.065300Z

hmm thats the only recent code gen bug I can remember

mkvlr 2019-10-29T08:22:25.065600Z

we’ll try an update anyway

dpsutton 2019-10-29T12:48:07.067100Z

@mkvlr do you use a top level letfn form by any chance? This can produce functions without namespaces

mkvlr 2019-10-29T12:57:52.067500Z

@dpsutton no, at least not in our code directly

kommen 2019-10-29T14:28:57.071100Z

to clarify: the invalid js files produced as @mkvlr described are not deterministic, so when just changing whitespace in the cljs file and recompiling, the js file is ok again. we do use figwheel-main with live code reload, not sure if this can be a factor here

thheller 2019-10-29T14:50:20.071900Z

how does the actual .js file look? I had some very weird output when 2 separate threads/processes were writing the same file at rougly the same time

thheller 2019-10-29T14:53:15.072300Z

dunno about figwheel through