cljs-dev

ClojureScript compiler & std lib dev, https://clojurescript.org/community/dev
p-himik 2019-12-03T11:44:52.471900Z

It seems that it's impossible to run a CLJS REPL on a host other than localhost without repeating the host twice: clj --main cljs.main -ro '{:host "192.168.1.220"}' -co '{:closure-defines {"clojure.browser.repl.HOST" "192.168.1.220"}}' --repl That's because of this line: https://github.com/clojure/clojurescript/blob/master/src/main/cljs/clojure/browser/repl.cljs#L31 Shouldn't the value of clojure.browser.repl.HOST be the same as :host in -ro at all times?

p-himik 2019-12-03T11:47:38.472200Z

Also, it looks like the --host value should replace the :host value in -ro, but that doesn't happen. The option seems to be completely ignored.

dnolen 2019-12-03T14:05:47.472800Z

they should be the same - that google define should be set by the browser REPL - if not - just a bug

dnolen 2019-12-03T14:06:18.473300Z

note it won't work if you already compiled and then change the host

dnolen 2019-12-03T14:06:36.473800Z

at least I don't think it will - you need a clean build if you change that value

p-himik 2019-12-03T14:16:42.474300Z

Yep, did a clean build. Still works only with :closure-defines .

dnolen 2019-12-03T14:20:21.474800Z

ok open a ticket - and a patch for the problem is welcome

dnolen 2019-12-03T14:21:10.475500Z

I don't think we've done much testing of other domains as it's less common thing to do - other REPLs like Figwheel probably handle this better

p-himik 2019-12-03T14:25:35.476500Z

I thought the issue tracker is off limits now, no? The page at https://clojurescript.org/community/reporting-issues says about describing an issue at http://ask.clojure.org to let the developers know. I can basically duplicate what I've written here if you want though.

alexmiller 2019-12-03T14:32:23.477300Z

if you don't have jira access, and you're not going to work on the patch, then either someone with access should log or you can file a question on ask.clojure

👍 1
alexmiller 2019-12-03T14:32:52.478Z

if you want to work on the patch, then sign the CA, and submit a request to get a jira acct, and make a jira