Clojurians Log v2
Clojure programming
Channels
Apps
cljs-dev
ClojureScript compiler & std lib dev, https://clojurescript.org/community/dev
alexmiller 2020-01-28T16:24:26.004100Z
https://clojure.atlassian.net/projects/CLJS/issues/CLJS-3208
juhoteperi 2020-01-28T20:26:38.006Z
I've just added direct dependency to java-protobuf 3.4.0 on projects where I have run nvd, haven't had any problems with that. So that can be a fix if (when) updating Closure compiler isn't that simple.
dnolen 2020-01-28T20:27:44.006800Z
yeah that's an ok workaround, but we really are way behind on the Closure Compiler releases - looking into updating to the latest now
dnolen 2020-01-28T20:28:02.007300Z
I patched up the goog-define issues in a branch and now looking at what's going wrong w/ module processing
thheller 2020-01-28T23:40:37.009300Z
@dnolen FWIW I think you are making the goog-define stuff much more complicated than it needs to be. I patched it in shadow-cljs by just adding :jsdoc meta, no need to go into the compiler for that. (its a function because I alter-var-root the macro var) https://github.com/thheller/shadow-cljs/blob/e77f60936cb5f63ba664212e5aa68b157e2fafc5/src/main/shadow/build/cljs_hacks.cljc#L657-L685
dnolen 2020-01-28T23:57:43.011900Z
Yeah could simplify it for sure
dnolen 2020-01-28T23:58:23.012500Z
But it’s really just a detail to fixing up the other issues