Clojurians Log v2

There are quite a few failures in Canary (https://github.com/cljs-oss/canary). I haven't yet had time to assess them.

@kommen I removed everything intentionally - but I'm ok w/ reverting the compile target bit for :graaljs if you want to make a revert patch for that + a test that would be helpful

@dnolen ok, can do that

@mfikes they seem configuration oriented? though I have to say I'm not so familiar with the Canary output

all the failures seem of the same kind?

in the long run, would you consider making compile targets pluggable, i.e a multimethod?

@kommen I mean ideally we could just do that now

if you want to take that step so you can get this working w/o putting :graaljs back in that would be best

👌

one thing is that I would say multimethod is probably not what we want

in general I think the preferred way is a symbol in the build config

which will be dynamically resolved

so something along the lines as shadow does: https://github.com/thheller/shadow-cljs/blob/fda0dc02d8199d5475a3ab42a3d2fd247c237235/src/main/shadow/build.clj#L166-L182

yes

@dnolen Yes, the failures seem to fall roughly into two categories. And I wouldn't be surprised if they are solvable in those downstream projects without changes in ClojureScript.

@mfikes I can try to fix my projects now, any hints what to try welcome

I haven't yet had a chance to look into them. Don't have anything to offer yet.

Truth be told, I did look at cljs-time. It was referring to the Rhino REPL but not using it. Simple fix there.

@darwin https://travis-ci.org/github/binaryage/cljs-devtools/builds/665810567

I have multiple “xxx.js requires transpilation….“, like here https://travis-ci.org/github/binaryage/cljs-oops/builds/665810571#L1015

looks like munging tests are failing for you?

@dnolen yes, that is likely, that will be an easy fix

@darwin the requires transpilation stuff seems a bit strange - only would happen if you're loading :none compiled stuff

in browser/Node REPLs won't matter because the debug loader will take care of it

but in other contexts it will cause trouble

thanks, looking into it my test js file is injected here by phantom: https://github.com/binaryage/cljs-oops/blob/master/test/resources/phantom.js#L39 and compiled from this config: https://github.com/binaryage/cljs-oops/blob/master/project.clj#L96

right that might not work

I don't have an easy answer for what you're doing

I think this is caused by phantom js runtime being too old. When I load the same file in normal browser, it works as expected. I’m going to rewrite the test runner to pupeteer to see if it fixes the issue…

👍:skin-tone-4:

just FYI, canary issues in my repos had two sources: 1) using phantom.js => fixed by switching to puppeteer 2) using goog.dependencies_[1] [1] https://github.com/binaryage/cljs-devtools/commit/8dd8b9c5d60c05d5ba5b60f2d908bb3eab8e2f8d