cljs-dev

ClojureScript compiler & std lib dev, https://clojurescript.org/community/dev
dnolen 2020-03-31T16:45:08.122900Z

this change should make it a bit easier for REPL developers to just focus on the stuff the matters and re-use everything else

dnolen 2020-03-31T17:54:19.123600Z

@alexmiller this is actually a pretty nasty ClojureScript core.async that Kevin Downey fixed four years ago - https://clojure.atlassian.net/projects/ASYNC/issues/?filter=allopenissues&orderby=priority%20DESC&keyword=with-redef

dnolen 2020-03-31T17:54:42.124300Z

any reason you see for not applying that and cutting a release?

alexmiller 2020-03-31T17:55:08.125100Z

Nope, I can do it in a little bit if it looks good to you

alexmiller 2020-03-31T17:56:11.125800Z

There are a bunch of cljs async bugs if you wanted to review any other ones

dnolen 2020-03-31T17:58:16.126100Z

I'm happy to got a query for me to look at?

dnolen 2020-03-31T17:59:32.126300Z

@alexmiller ^

alexmiller 2020-03-31T18:10:49.126900Z

Away from computer, give me 15

dnolen 2020-03-31T18:17:50.127200Z

k no rush

alexmiller 2020-03-31T18:21:06.127500Z

https://clojure.atlassian.net/issues/?filter=10025 - all core.async CLJS tickets in decreasing priority

alexmiller 2020-03-31T18:22:06.127800Z

your query above was a little ambiguous - did you mean https://clojure.atlassian.net/browse/ASYNC-165 ?

dnolen 2020-03-31T18:33:51.128Z

ah yeah

dnolen 2020-03-31T18:33:57.128400Z

you already merged it

alexmiller 2020-03-31T18:35:56.128700Z

core.async currently depends on 0.0-2311 which is ... old

alexmiller 2020-03-31T18:36:13.129100Z

what should that be bumped up to?

dnolen 2020-03-31T18:45:11.129500Z

hrm really, project.clj says 1.1.170

alexmiller 2020-03-31T18:45:32.129900Z

sorry, I was talking pom

alexmiller 2020-03-31T18:45:39.130200Z

I guess in this case the project is more relevant

alexmiller 2020-03-31T18:45:48.130500Z

but anyways, that's also old :)

dnolen 2020-03-31T18:47:20.130700Z

haha

dnolen 2020-03-31T18:47:38.131200Z

it doesn't really matter that much to be honest

dnolen 2020-03-31T18:47:50.131600Z

at some point I'd like to update the tests to something more modern

dnolen 2020-03-31T18:48:06.132Z

but not high piority, cljsbuild works fine and so does the version of ClojureScript for testing purposes

alexmiller 2020-03-31T18:51:19.132400Z

do you mind if I bump up to latest?

alexmiller 2020-03-31T18:51:42.132900Z

this also affects the clojure version in there, and then bumping that leads to (fixed) spec issues in cljs and cljsbuild

alexmiller 2020-03-31T18:52:03.133300Z

everything seems good on newer versions

dnolen 2020-03-31T19:07:10.133700Z

@alexmiller go for it!

alexmiller 2020-03-31T19:09:16.134400Z

let me know when you hit a stopping point with patches

alexmiller 2020-03-31T19:10:12.134700Z

I'll update that, and the readme, and do a release

dnolen 2020-03-31T19:18:13.135100Z

almost done

dnolen 2020-03-31T19:18:20.135500Z

I only looked at things with patches

dnolen 2020-03-31T19:19:03.136200Z

@filipematossilva applying your interop patch, sorry for delay

⛄ 1
dnolen 2020-03-31T19:19:19.136600Z

going to add EXPERIMENTAL to the docstrings so there's some time for feedback

dpsutton 2020-03-31T19:19:59.137100Z

thanks for merging my first contribution to core.async!

dnolen 2020-03-31T19:25:04.137500Z

@dpsutton thanks for submitting a patch! sorry for the delay

1
dnolen 2020-03-31T19:25:11.137700Z

@alexmiller I'm done now

alexmiller 2020-03-31T19:25:24.138Z

ok, I'll take it from here!

Filipe Silva 2020-03-31T19:30:56.138200Z

sweet, looking forward to it!