I'm not sure who I should ping about the closurescript site, but the interop patch also included docs
@dnolen @alexmiller could this be merged as well?
ehm that cljs.core.async.interop
CLJS ns is missing the :require-macros
for itself. makes it kinda annoying to use. https://github.com/clojure/core.async/commit/4b71889e1ba2c909ff30e75af37f7c41e0b75fc7
@thheller hrm weird that it seems the tests passed w/o that, thanks adding now
@alexmiller would need another bump w/ the change I just pushed
ok, will do
will get the doc too
must have been because the tests used :refer-macros
(ns cljs.core.async.interop-tests
(:require-macros [cljs.core.async.macros :refer [go]])
(:require [cljs.core.async :refer [<!]]
[cljs.core.async.interop :refer [p->c] :refer-macros [<p!]]
[cljs.test :refer-macros [deftest is async]]))
sorry about that 😐
core.async 1.1.587 is working its way through maven
new doc page is up at https://clojurescript.org/guides/promise-interop
also, I applied a pre block scroll css fix that we added recently on the clojure site so some of that stuff looks better
very excited to see my contribution there 😄 (even though it was mostly copy paste of David's code)
this is great! Thanks all!
still waiting on maven - at the end of the month they have some big batch stats job that always slows things down for a few days
With ClojureScript master and a downstream re-natal
-based project I get "Cannot use default debug loader outside of HTML documents."
I'm going on the assumption that this is not a ClojureScript problem but instead re-natal
(or Figwheel) would need to be updated for the latest Closure stuff. (Planning on logging a downstream ticket if I can get a clean repro there.)
@kommen hey I've added :target-fn
to master to allow custom bootstrapping code for :none
mode
@mfikes re: re-natal that might be easy to fix, the issue is that re-natal doesn't define CLOSURE_IMPORT_SCRIPT
rather it uses FIGWHEEL_IMPORT_SCRIPT
which seems dubious, but maybe necessary for Figwheel to handle it's hot-reloading?
@dnolen ok, thanks. I’ll use that for graaljs