cljs-dev

ClojureScript compiler & std lib dev, https://clojurescript.org/community/dev
Filipe Silva 2020-04-01T09:02:58.138900Z

I'm not sure who I should ping about the closurescript site, but the interop patch also included docs

Filipe Silva 2020-04-01T09:03:00.139100Z

https://github.com/clojure/clojurescript-site/pull/331

🎉 1
Filipe Silva 2020-04-01T09:05:45.139900Z

@dnolen @alexmiller could this be merged as well?

thheller 2020-04-01T10:02:22.140400Z

ehm that cljs.core.async.interop CLJS ns is missing the :require-macros for itself. makes it kinda annoying to use. https://github.com/clojure/core.async/commit/4b71889e1ba2c909ff30e75af37f7c41e0b75fc7

👍 1
dnolen 2020-04-01T10:20:54.141Z

@thheller hrm weird that it seems the tests passed w/o that, thanks adding now

👍 2
dnolen 2020-04-01T13:15:04.141500Z

@alexmiller would need another bump w/ the change I just pushed

alexmiller 2020-04-01T13:15:11.141700Z

ok, will do

alexmiller 2020-04-01T13:15:22.141900Z

will get the doc too

Filipe Silva 2020-04-01T13:29:44.142200Z

must have been because the tests used :refer-macros

Filipe Silva 2020-04-01T13:29:45.142400Z

(ns cljs.core.async.interop-tests
  (:require-macros [cljs.core.async.macros :refer [go]])
  (:require [cljs.core.async :refer [<!]]
            [cljs.core.async.interop :refer [p->c] :refer-macros [<p!]]
            [cljs.test :refer-macros [deftest is async]]))

Filipe Silva 2020-04-01T13:29:49.142600Z

sorry about that 😐

alexmiller 2020-04-01T13:33:05.143100Z

core.async 1.1.587 is working its way through maven

alexmiller 2020-04-01T13:33:11.143300Z

new doc page is up at https://clojurescript.org/guides/promise-interop

alexmiller 2020-04-01T13:35:50.144100Z

also, I applied a pre block scroll css fix that we added recently on the clojure site so some of that stuff looks better

❤️ 1
Filipe Silva 2020-04-01T13:45:51.144900Z

very excited to see my contribution there 😄 (even though it was mostly copy paste of David's code)

🤘 2
dnolen 2020-04-01T13:57:18.145200Z

this is great! Thanks all!

⛄ 1
alexmiller 2020-04-01T13:58:28.145800Z

still waiting on maven - at the end of the month they have some big batch stats job that always slows things down for a few days

mfikes 2020-04-01T16:16:37.148300Z

With ClojureScript master and a downstream re-natal-based project I get "Cannot use default debug loader outside of HTML documents." I'm going on the assumption that this is not a ClojureScript problem but instead re-natal (or Figwheel) would need to be updated for the latest Closure stuff. (Planning on logging a downstream ticket if I can get a clean repro there.)

dnolen 2020-04-01T16:23:20.148900Z

@kommen hey I've added :target-fn to master to allow custom bootstrapping code for :none mode

dnolen 2020-04-01T16:38:59.149600Z

@mfikes re: re-natal that might be easy to fix, the issue is that re-natal doesn't define CLOSURE_IMPORT_SCRIPT

dnolen 2020-04-01T16:40:32.151200Z

rather it uses FIGWHEEL_IMPORT_SCRIPT which seems dubious, but maybe necessary for Figwheel to handle it's hot-reloading?

kommen 2020-04-01T19:33:21.152100Z

@dnolen ok, thanks. I’ll use that for graaljs