I haven't heard much since last weekend's release issues, anything I missed that should go into a bugfix release?
haven’t had the chance to play with the :bundle
target in depth yet, but to respond to the above re: the guide, I think that tekacs was reading the guide step by step and didn’t understand the state they were in would be remedied by executing the next step.
I am puzzled why :bundle
creates a main.js or the cljs http server serves a main.js if one isn’t there, let alone why it appears to be in such a broken state (it contains clearly invalid JS)
might not be worth fixing atm, since the happy path does work once we figured it out
@lilactown :bundle
doesn't create anything itself, it respects :output-to
like all other targets
the browser REPL attempts to serve main.js
if it exists
so I'm really still not clear on what the problem was
other than something lacking clarity in the guide
it appeared to be serving a main.js
that did not exist on disk
I don't understand
how could the next step fix it?
maybe pointing to the specific part of the guide where this happens would shed some light
I just copy and paste the steps when I do it and it works
so something must have happened out of order
https://clojurians.slack.com/archives/C03S1L9DN/p1588204758101200
the user setup a cljs build with target :bundle
, but did not try to bundle it in any way with a JS bundler yet
they ran a CLJS REPL and navigated to localhost:9000 and get a broken main.js
so they didn't follow the tutorial
there's nothing to do here
bundling the code with parcel or webpack to generate a main.js
on disk fixed it
they never generated main.js
the browser repl couldn't find it
nothing is going to work
the order of the tutorial prevents this
😄 if you see no issue here, then I’ll drop it. I think the user had an expectation to follow the guide step by step and when they got into a broken state, instead of continuing they tried to understand the broken state.
serving a broken main.js
if one isn’t on disk seems weird, but if you see no issue then I won’t pursue further
@lilactown there's just lack information in nearly everything that has been said so far 🙂
Yup it’s the latter that’s a concern more than anything else @dnolen
so I can't help if I don't understand
So — if you don’t run the bundler, it serves a main.js even if there’s not one on disk
Seemingly one that’s generated on the fly?
but what does "broken" mean here?
Broken in the way I outlined in the original thread — it has incorrectly generated JS syntax in it
ah k
I appreciate that you’re told to run the bundler first, but if (like me) you’re trying to adapt the tutorial for another bundler and it fails to generate main.js, you’re going to be fairly confused when the server ‘correctly’ serves a main.js when there’s none on disk... only one that’s broken
so I found the bug in browser REPL and that is fixed
but that not going to help w/ any confusion about :bundle
and browser REPL
since they are in fact independent features
If it served a 404 that’d be amazing — or even a working (but not the bundled) file.
browser REPL generates a main.js
if none found so you can use the browser REPL anywhere you want
@tekacs what I just said makes that undesirable
you don't need a project to start browser REPL
or any source files at all
just like the Node REPL
Yup that makes total sense — I think even this is less confusing
If it weren’t broken then you could continue without feeling that something is blocking
for sure, thanks for bringing up again @lilactown and being patient with my confusion about what was going on
Thank you for fixing that!
When I saw invalid generated JS I thought I was going crazy :)
Building 1.10.753 now
feel free to give it a spin when it appears, if I don't hear anything bad over the weekend will put together an announce post