cljs-dev

ClojureScript compiler & std lib dev, https://clojurescript.org/community/dev
alexmiller 2020-05-06T18:28:27.288700Z

@dnolen @mfikes I looked at the cljs testing stuff a bit. I think probably the easiest thing is if you could convert that travis build into a docker file, which I could then easily run in jira. the alternative is installing a bunch of stuff on the build box and there are a bunch of reasons why that's non-ideal.

mfikes 2020-05-06T18:30:29.289100Z

Seems reasonable to me.

dnolen 2020-05-06T18:33:46.289600Z

@alexmiller so the idea is here is just use JIRA support to apply the patch and run tests?

alexmiller 2020-05-06T18:36:14.290Z

maybe I misunderstand what you're looking for, so let's step back ...

alexmiller 2020-05-06T18:36:24.290300Z

I thought you were looking for a way to automatically run all tests on commit

dnolen 2020-05-06T18:36:48.291Z

@alexmiller oh JIRA has a view for that?

alexmiller 2020-05-06T18:36:55.291400Z

no

dnolen 2020-05-06T18:36:58.291600Z

or you just mean run in JIRA

dnolen 2020-05-06T18:37:03.292Z

and use the hook for GitHub - ok

alexmiller 2020-05-06T18:37:25.292400Z

crap, I said jira before but I meant jenkins

dnolen 2020-05-06T18:37:37.292600Z

haha

dnolen 2020-05-06T18:37:41.292900Z

I was pretty confused

alexmiller 2020-05-06T18:37:43.293100Z

me too

alexmiller 2020-05-06T18:37:49.293300Z

and it was my fault :)

dnolen 2020-05-06T18:38:01.293900Z

cool, sounds reasonable to me

alexmiller 2020-05-06T18:38:15.294200Z

so, is goal to run all tests with each commit or to have a place to test patches with feedback ?

dnolen 2020-05-06T18:38:31.294600Z

the first thing is higher priority

dnolen 2020-05-06T18:38:37.294800Z

then we know if something is actually releasable

dnolen 2020-05-06T18:38:50.295400Z

the later thing would be icing if related

alexmiller 2020-05-06T18:38:52.295500Z

ok, I think the latter would build on the former anyway

alexmiller 2020-05-06T18:39:23.296Z

well, docker-izing the test would be the best path imo as it clarifies the system install requirements

dnolen 2020-05-06T18:55:56.298300Z

would it be easy to partition by runtime kinda like how the JVM version stuff works for Clojure?

dnolen 2020-05-06T18:56:31.298800Z

Testing V8, Node, JSC seems like a good start - and of course we need Node.js

Oliver George 2020-05-06T23:14:58.299500Z

Hi All, I'm seeing compiler errors on windows. Just wondering if that's interesting or known.

Oliver George 2020-05-06T23:15:19.299900Z

Quick example here. https://gist.github.com/olivergeorge/4654a332cf45d438ee6009873a3fb2fe

Oliver George 2020-05-06T23:15:20.300Z

Oliver George 2020-05-06T23:16:04.301300Z

I had the feeling there were Windows CI tests.

Oliver George 2020-05-06T23:21:01.301600Z

If it's worth tracking down I'll do a minimal repro