cljs-dev

ClojureScript compiler & std lib dev, https://clojurescript.org/community/dev
dnolen 2020-05-11T13:33:52.337400Z

@bhauman hrm a bunch of users have already gone through that I'm pretty sure it's not redundant

dnolen 2020-05-11T13:34:06.337700Z

I also went through it via copy paste

bhauman 2020-05-11T16:26:29.338600Z

@dnolen no really it outputs it to out/out/main.js

bhauman 2020-05-11T16:26:36.338900Z

the example still works

bhauman 2020-05-11T16:26:54.339300Z

but it works in a less confusing manner if you get rid of one ot the out dirs

dnolen 2020-05-11T16:27:13.339800Z

ah k

๐Ÿ‘ 1
bhauman 2020-05-11T16:27:17.339900Z

otherwise folks are left thinking its necessary

bhauman 2020-05-11T16:29:04.340800Z

btw the :bundle target is fantastic

๐Ÿ’ฏ 1
dnolen 2020-05-11T16:29:06.340900Z

merged

dnolen 2020-05-11T16:29:33.341500Z

@bhauman yeah I'm assuming making Figwheel work w/ it is pretty easy-going

dnolen 2020-05-11T16:30:00.342200Z

@alexmiller website could use bump

bhauman 2020-05-11T16:30:05.342400Z

lein-figwheel was tough getting around the closure changes

alexmiller 2020-05-11T16:30:08.342600Z

Ok

bhauman 2020-05-11T16:30:28.343100Z

but after that pretty simple, Iโ€™m about to deploy lein-figwheel

dnolen 2020-05-11T16:30:42.343800Z

@bhauman ah right yeah, the Closure changes were painful

bhauman 2020-05-11T16:31:07.344200Z

figwheel-main isnโ€™t done yet, all in all its been some hours though ๐Ÿ™‚

dnolen 2020-05-11T16:31:34.344400Z

heh

thheller 2020-05-11T21:32:29.345300Z

@alexmiller there seems to be a problem in the latest core.async release.

------ WARNING #1 - :undeclared-var --------------------------------------------
 Resource: cljs/core/async.cljs:396:15
--------------------------------------------------------------------------------
 393 |   but can be determined by the close? parameter.
 394 |
 395 |   Returns a channel which will close after the items are copied."
 396 |   ([ch coll] (onto-chan ch coll true))
---------------------^----------------------------------------------------------
 Use of undeclared Var cljs.core.async/onto-chan
--------------------------------------------------------------------------------
 397 |   ([ch coll close?]
 398 |      (go-loop [vs (seq coll)]
 399 |               (if (and vs (>! ch (first vs)))
 400 |                 (recur (next vs))
--------------------------------------------------------------------------------

thheller 2020-05-11T21:33:53.345500Z

I think thats onto-chan! now?

alexmiller 2020-05-11T22:08:58.345800Z

onto-chan should still exist, just deprecated

alexmiller 2020-05-11T22:10:17.346100Z

ah, that is a bug there though

alexmiller 2020-05-11T22:10:52.346300Z

fixing

2020-05-11T22:14:03.347200Z

alex: just curious, anyone reported compiler stack overflow after upgrading to 1.1.587 (from 1.0.567)?

2020-05-11T22:14:56.348200Z

I had this issue but didnโ€™t have time to track it down or write a proper ticket, unfortunately travis logs are gone now, downgraded instead: https://github.com/binaryage/dirac/commit/2a47dcce1f9b93e16566f95cfa642ddef3b38511

alexmiller 2020-05-11T22:17:23.348500Z

nope

2020-05-11T22:18:37.349200Z

it is probably on my side, will have to dive deeper, the stack trace looks like this: https://travis-ci.org/github/binaryage/dirac/builds/675503493#L571

alexmiller 2020-05-11T22:21:51.349800Z

seems like it would be good to capture that for David or someone to look at

alexmiller 2020-05-11T22:23:17.351200Z

@thheller core.async 1.2.603 is on its way, will probably be available in ~15 min

๐Ÿ‘ 2
2020-05-11T22:23:21.351300Z

since it affects only my test code, I have a hunch that this hacky code could be causing it: https://github.com/binaryage/dirac/blob/master/src/automation/dirac/automation.clj#L27-L37 something in new core.async could affect it