@bhauman hrm a bunch of users have already gone through that I'm pretty sure it's not redundant
I also went through it via copy paste
@dnolen no really it outputs it to out/out/main.js
the example still works
but it works in a less confusing manner if you get rid of one ot the out
dirs
ah k
otherwise folks are left thinking its necessary
btw the :bundle
target is fantastic
merged
@bhauman yeah I'm assuming making Figwheel work w/ it is pretty easy-going
@alexmiller website could use bump
lein-figwheel was tough getting around the closure changes
Ok
but after that pretty simple, Iโm about to deploy lein-figwheel
@bhauman ah right yeah, the Closure changes were painful
figwheel-main isnโt done yet, all in all its been some hours though ๐
heh
@alexmiller there seems to be a problem in the latest core.async release.
------ WARNING #1 - :undeclared-var --------------------------------------------
Resource: cljs/core/async.cljs:396:15
--------------------------------------------------------------------------------
393 | but can be determined by the close? parameter.
394 |
395 | Returns a channel which will close after the items are copied."
396 | ([ch coll] (onto-chan ch coll true))
---------------------^----------------------------------------------------------
Use of undeclared Var cljs.core.async/onto-chan
--------------------------------------------------------------------------------
397 | ([ch coll close?]
398 | (go-loop [vs (seq coll)]
399 | (if (and vs (>! ch (first vs)))
400 | (recur (next vs))
--------------------------------------------------------------------------------
I think thats onto-chan!
now?
onto-chan should still exist, just deprecated
ah, that is a bug there though
fixing
alex: just curious, anyone reported compiler stack overflow after upgrading to 1.1.587 (from 1.0.567)?
I had this issue but didnโt have time to track it down or write a proper ticket, unfortunately travis logs are gone now, downgraded instead: https://github.com/binaryage/dirac/commit/2a47dcce1f9b93e16566f95cfa642ddef3b38511
nope
it is probably on my side, will have to dive deeper, the stack trace looks like this: https://travis-ci.org/github/binaryage/dirac/builds/675503493#L571
seems like it would be good to capture that for David or someone to look at
@thheller core.async 1.2.603 is on its way, will probably be available in ~15 min
since it affects only my test code, I have a hunch that this hacky code could be causing it: https://github.com/binaryage/dirac/blob/master/src/automation/dirac/automation.clj#L27-L37 something in new core.async could affect it