Clojurians Log v2
cljs-dev
hmmm do :closure-defines work for the new :bundle target?
@dnolen just confirmed that CLOSURE_UNCOMPILED_DEFINES and CLOSURE_NO_DEPS don’t make it through the bundler properly, they probably need to be exported to the global window object
could append window.CLOSURE_UNCOMPILED_DEFINES = CLOSURE_UNCOMPILED_DEFINES; at the end of the boot script after the window.require override
What optimizations are we talking about?
Oh I’m assuming :none I guess
yeah :none
@dnolen ^
@bhauman fixed in master, give it a try
thanks man
yeah that should do it
@bhauman let me know when you have something that appears to work - happy to cut an official bug fix release just so that Figwheel has something to align with
@dnolen will do
will let you know in a few minutes
if there's any other bugs that could use fixing for such a release let me know
@dnolen that did it for me, figwheel-main is now working
sweet!
@bhauman and lein-figwheel already all good too?
yep
🙂
its didn’t use closure defines 🙂
@dnolen actually wait a few,
I have a test suite I should run
yeah I'll wait, no rush
might be good to see if people want to kick it too with a CLJS git-dep
oh yeah
I think maybe should just wait till Friday to let the feedback roll in
A few docsctrings are placed after the binding form in the clojurescript source. There are also some typos: https://github.com/laurio/clojurescript/pull/1/files Would you be interested in opening a Jira issue so i can submit a patch?
@lauri yes thanks! have you submitted your CA?
@dnolen its all working. It would be nice to have a release sooner than later, as I’d like to have this milestone achieved 🙂
@bhauman 1.10.764 should be going out soon
@dnolen I have submitted my CA (have done few contributions in 2016).
@lauri cool submit a patch!
Will do it in the morning! Can I create an issue in Jira myself - couldn’t find this option there at the moment.
Sorry, now I found this button - will create the issue.