Clojurians Log v2

commit 42bcb07b8bf23d57f98e4617e4c4c93347f09715
Author: dnolen <david.nolen@gmail.com>
Date:   Sat Jun 6 12:35:05 2020 -0400

    compute-npm-deps needs to check for :npm-deps true case

diff --git a/src/main/clojure/cljs/closure.clj b/src/main/clojure/cljs/closure.clj
index b5a0d1c0..12df2f61 100644
--- a/src/main/clojure/cljs/closure.clj
+++ b/src/main/clojure/cljs/closure.clj
@@ -2437,7 +2437,7 @@
      (reduce
        (fn [m [dep v]]
          (cond-> m
-           (not (contains? npm-deps dep))
+           (and (map? npm-deps) (not (contains? npm-deps dep)))
            (assoc dep (if (coll? v)
                         (last (sort v))
                         v))))

@plexus I've been using master and I haven't had any problems

can you be more specific?

@alexmiller I notice that we only have a low resolution logo for the ClojureScript site instead serving a higher one for retina displays

you mean icon or on the site?

if you want to file an issue and assign it to me I can look at it, probably won't be for a bit

the logo on the site

Clojure one looks like it has a higher resolution one

certainly fixable. I did change it not too long ago I think b/c it was huge, but surely there is a happy medium :)

huh that's probably it 🙂

oh ...

also probably why it was flashing

yeah, that was part of it

it wasn't sized

ok I assigned it to you

but I can make that better

thanks!

@thheller merged CLJS-3200 patch

Ahh cool. I got a CI failure notification for the above off on my own "CI fork" as a result of the new GitHub actions. Looks like the main repo is also showing the same.

weird failure

yeap, might be JSC related, going to revert for now and look into it later