cljs-dev

ClojureScript compiler & std lib dev, https://clojurescript.org/community/dev
dnolen 2021-05-14T15:44:51.171500Z

@alexmiller https://github.com/clojure/clojurescript-site/commit/59a049f66d56bd2fe33c530ec7bbe145475a00a1 can we rebuild the site w/ newer clj command?

dnolen 2021-05-14T16:04:22.171800Z

one more change for code splitting guide

alexmiller 2021-05-14T16:11:15.172100Z

will do

alexmiller 2021-05-14T16:12:43.172300Z

pushed

dnolen 2021-05-14T16:36:11.172600Z

looking at bumping Closure to prep for next release

dnolen 2021-05-14T16:36:19.172900Z

if there's anything important you all think I should look at now is the time

dnolen 2021-05-14T16:39:46.173300Z

@alexmiller building google-closure-library would need a release of that as well

dnolen 2021-05-14T16:39:53.173500Z

(unless that's automated now)

dnolen 2021-05-14T16:42:39.173900Z

@alexmiller re: site needs another bump -- missed clj --main ...

alexmiller 2021-05-14T16:46:55.174100Z

site building

alexmiller 2021-05-14T16:47:05.174400Z

will build google-closure

dnolen 2021-05-14T16:57:08.174700Z

I triggered the build, just needs release steps - thanks!

alexmiller 2021-05-14T16:58:43.174900Z

yeah, I missed that and redid it :)

alexmiller 2021-05-14T16:58:59.175300Z

I just released though, will take 10-15m to show up

alexmiller 2021-05-14T17:09:58.176Z

org.clojure/google-closure-library 0.0-20210512-04d6fb3b org.clojure/google-closure-library-third-party 0.0-20210512-04d6fb3b

alexmiller 2021-05-14T17:10:02.176200Z

available now

dnolen 2021-05-14T17:21:18.176400Z

🎉

dnolen 2021-05-14T17:31:10.176900Z

@alexmiller looks like Google Closure Lib is now broken for how we consume it - a battle for another day

alexmiller 2021-05-14T17:32:41.177100Z

:(

dnolen 2021-05-14T17:38:52.177700Z

The stability of Closure Compiler and Lib has really fallen low

dpsutton 2021-05-14T17:40:00.178300Z

do you mean it's buggy in the manner used in cljs or conceptually is moving away from the way cljs uses it?

dnolen 2021-05-14T17:40:22.178900Z

No just that everytime I’ve bumped in the past two years stuff is broken

dnolen 2021-05-14T17:40:45.179400Z

They don’t use semantic versioning but they also change stuff

dnolen 2021-05-14T17:41:27.180100Z

We’re somewhat unique consumers but I’m not even so sure about that

dnolen 2021-05-14T17:41:58.181200Z

My impression was that other users of Closure depend on some details as well for custom building

dnolen 2021-05-14T17:43:41.181700Z

glib also has a lot of low value refactoring

dnolen 2021-05-14T17:44:09.182400Z

Or perhaps can’t see how it could matter

dnolen 2021-05-14T17:45:49.184Z

Switching to ES6 classes and goog modules before

dnolen 2021-05-14T17:57:28.184800Z

@alexmiller that's interesting but probably incomplete? If we could get them in JIRA could help them take that past the finish line

alexmiller 2021-05-14T18:00:19.185100Z

I can fix them up, sounds like they have a CA already

alexmiller 2021-05-14T18:00:36.185500Z

(although I always wonder why people have more than 20 parameters :)

dnolen 2021-05-14T18:17:07.185800Z

😉

borkdude 2021-05-14T18:23:10.186200Z

perhaps a macro generated it?

alexmiller 2021-05-14T18:34:19.186600Z

"If you have a procedure with 10 parameters, you probably missed some." - Alan Perlis

😆 3
dnolen 2021-05-14T19:12:18.187400Z

I think bumping glib for next release is probably more trouble than it's worth - who knows what lurks beneath - can save it for later

dnolen 2021-05-14T19:12:32.187900Z

Again feel free to propose other tickets worth considering

dnolen 2021-05-14T19:33:54.188400Z

@alexmiller Windows support for clojure tool is pretty good now yes?

borkdude 2021-05-14T19:37:54.189900Z

The main problems with it are: it's powershell, so shelling out to it from, say, Java, or nodeJS, or whatever editor is problematic, as it's not a normal process you can start. Another problem is that it doesn't work from cmd.exe, as you always need to go through powershell first.

borkdude 2021-05-14T19:40:59.190600Z

https://github.com/borkdude/deps.clj solves some of these (in fairness, niche, because Windows usage is already niche in Clojure land) problems by providing a binary* instead which is a drop-in replacement for the official Clojure CLI *(or uberjar, or babashka script)

borkdude 2021-05-14T19:43:57.191600Z

@pez can probably tell you more from the editor integration side, as he dealt with a fair share of Windows people lately

borkdude 2021-05-14T19:45:37.192500Z

In general the -X style invocation causes some headaches for Windows users especially because quoting strings is pretty confusing in both cmd.exe and powershell

borkdude 2021-05-14T19:46:20.192900Z

There's also #clj-on-windows if you want to know more.

alexmiller 2021-05-14T19:52:54.193300Z

I think that is a fair accounting

borkdude 2021-05-14T19:54:18.194100Z

Probably for the most mainstream usage it works well, this must also be said. People for whom it works well, are the ones you never hear from ;)

lread 2021-05-14T20:58:22.200100Z

@dnolen on the Windows topic: way back I worked making https://clojure.atlassian.net/browse/CLJS-3098. I think you safely close this issue as stale. Would probably suggest rewriting bash scripts in Clojure if revisiting - and run through babashka or clojure.

pez 2021-05-14T20:59:06.200700Z

Another problem on Windows is that the java.exe that Oracle’s installer makes the default, borks double quoting (strips double quotes fully and totally) . So any invokation of clojure using that java.exe, involving double quoting anything, will fail. This since JDK11. See https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8266473

pez 2021-05-14T20:59:51.201300Z

This is regardless of powershell or cmd.exe and hits deps.clj as well.

lread 2021-05-14T21:02:08.202200Z

@dnolen If you are house-cleaning old issues, feel free to closeout https://clojure.atlassian.net/browse/CLJS-3075 too (kinda tied to Windows bash script work).

lread 2021-05-14T21:05:46.203700Z

@dnolen unrelated to Windows, but while I’m looking at CLJS issues I worked on… I think you aren’t even building on Travis CI anymore? So https://clojure.atlassian.net/browse/CLJS-3114 can die too. Oh and https://clojure.atlassian.net/browse/CLJS-3079 seems to have dependencies on Windows issue, so feel free to kill it too.