cljs-dev

ClojureScript compiler & std lib dev, https://clojurescript.org/community/dev
dnolen 2021-05-17T12:40:49.204700Z

@lee thanks for the headsup - yeah, closed those

👍 1
dnolen 2021-05-17T12:44:31.206400Z

@henryw374 open to that, add the patch to the issue

mfikes 2021-05-17T22:27:46.207200Z

Corner case with and / or : https://clojure.atlassian.net/browse/CLJS-3309

dnolen 2021-05-17T23:46:14.000400Z

@mfikes thanks! interesting no other tests failed that look like this

mfikes 2021-05-17T23:46:33.000700Z

Coal mine found a handful...

dnolen 2021-05-17T23:46:45.000900Z

all the same and only with or?

mfikes 2021-05-17T23:47:24.001700Z

Actually, I hadn't surveyed across all of them to see if there are any distinct things outside of the gensym issue... let me take a peek.

mfikes 2021-05-17T23:48:00.002100Z

Here is where I found them FWIW https://travis-ci.org/github/mfikes/coal-mine/builds/771413091

dnolen 2021-05-17T23:49:05.002900Z

all seem to involve or

mfikes 2021-05-17T23:49:15.003200Z

They all look like and and or gensym failures that all fall into the same "category"

dnolen 2021-05-17T23:49:42.003500Z

can you include an and repro in the issue?

mfikes 2021-05-17T23:49:45.003900Z

Here is an and one https://travis-ci.org/github/mfikes/coal-mine/jobs/771413094#L635

dnolen 2021-05-17T23:49:49.004300Z

would be a good unit test

mfikes 2021-05-17T23:50:00.004600Z

Yeah, I'll make a minimal from that one I just linked...

dnolen 2021-05-17T23:52:25.004900Z

thanks!

dnolen 2021-05-17T23:55:52.005200Z

@mfikes hrm it appears these all involve loop?

mfikes 2021-05-17T23:56:10.005600Z

The and one I'm making a minimal for involves a for it appears.

mfikes 2021-05-17T23:56:35.005800Z

((fn [s] (for [e (tree-seq sequential? seq s) :when (and (sequential? e) (every? (fn [x] (not (sequential? x))) e))] e)) [[1 2] [[3 4] [[[[5 6]]]]]])

mfikes 2021-05-17T23:56:46.006100Z

^ Trying to make that one a little smaller

dnolen 2021-05-17T23:59:55.006300Z

ah they are all similar