Clojurians Log v2

@leontalbot: cant find the channel we just wrote in. feel free to ask more q here

@martinklepsch: Thanks!

The author of tabletop.js does not provide .min.js files

do I minify myself?

@martinklepsch: ^^^

@leontalbot: there's a minify task

gotta run right now but it's in the same namespace as the download task. you can read the help if you run boot minify -h (assuming you have something like :refer [minify])

wonderful thanks @martinklepsch

hello.

I get a test fail https://circleci.com/gh/cljsjs/packages/453

was I suppose to commit with the target dir in the tabletop folder? cause I removed it to do like the rest of the libs

😞

"No test commands were found"

I would need help to understand what to do...

:simple_smile:

thanks

cc @martinklepsch

@leontalbot: Your branch is based on very old packages commit (680 commits behind master), so your branch doesn't contain the CI configuration

I went to https://github.com/cljsjs/packages and clicked fork... What should I have done?

(newbie)

It is probably some months since you forked it

no

today

Hmm, shouldn't happen. Anyway, you probably have currently one git remote set up, probably named origin and it points to your fork in github.

you can check this using git remote show origin

* remote origin
  Fetch URL: <https://github.com/leontalbot/packages.git>
  Push  URL: <https://github.com/leontalbot/packages.git>
  HEAD branch: master
  Remote branches:
    foreign-libs        tracked
    foreign-libs-link   tracked
    highlight           tracked
    issue-47            tracked
    master              tracked
    native-closure      tracked
    openlayers-all-exts tracked
    patch-1             tracked
    pdf.js              tracked
    react-0.13          tracked
    tabletop            tracked
    test-utils-extern   tracked
  Local branches configured for 'git pull':
    master   merges with remote master
    tabletop merges with remote tabletop
  Local refs configured for 'git push':
    master   pushes to master   (up to date)
    tabletop pushes to tabletop (up to date)

You can add second git remote using git remote add upstream git@github.com:cljsjs/packages.git and then you can use this upstream remote to load latest changes into your local copy

something like git checkout master (move to local master branch), git pull upstream master (update local master branch to match upstream remote), git checkout tabletop (move back to feature branch) and git merge master (merge changes from master back to the feature branch)

great ! trying...

git pull upstream master
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Oh right, you should use https url for upstream repo as you don't have commit rights

git remote set-url upstream <https://github.com/cljsjs/packages.git>

excellent! Thanks @juhoteperi!

Pull request just sent!

@leontalbot: Commented on PR about the extern file

@juhoteperi to make sure I do the extern correctly...

var Tabletop = {
    "callbacks": function () {},
    "init": function () {},
    "sheets": function () {},
    "Model": function () {}
}

@leontalbot: Yes, something like that

pull-requested!

@juhoteperi hope the externs look good now :simple_smile:

@juhoteperi: thanks for the merge!