cljsjs

adamw 2016-07-29T07:36:50.000109Z

Hi folks, apologies; when trying to package a new library I'm getting an error

java.lang.AssertionError: Assert failed: No .inc.js file found!
                            regular
Download/checksum &c. all seem to work fine so I guess my sift is at fault. How can I find out where the zip file has been downloaded by boot package, because I don't see anything wrong with my sift targets.

anmonteiro 2016-07-29T15:57:46.000115Z

I’m having a problem by importing cljsjs.highlight.langs.clojure and cljsjs.codemirror.mode.clojure

anmonteiro 2016-07-29T15:57:58.000116Z

both are named clojure.inc.js so I end up really only having one of them

anmonteiro 2016-07-29T15:58:02.000118Z

¯\(ツ)

anmonteiro 2016-07-29T15:58:12.000119Z

anyone knows how to solve this?

juhoteperi 2016-07-29T17:10:00.000120Z

@anmonteiro: It would be best to move them to separate dirs, mode/clojure.inc.js and langs/clojure.inc.js

juhoteperi 2016-07-29T17:10:18.000121Z

shouldn't be breaking change as hopefully no one is directly using the filepath

anmonteiro 2016-07-29T17:10:43.000122Z

@juhoteperi: according to the discussion in #C03S1L9DN it seems that this should be solved in the compiler itself

juhoteperi 2016-07-29T17:10:51.000123Z

Oh

anmonteiro 2016-07-29T17:11:10.000124Z

the problem is that both clojure.inc.js end up at the root of the :output-dir

juhoteperi 2016-07-29T17:11:24.000125Z

Ah

anmonteiro 2016-07-29T17:11:37.000126Z

I’ve created http://dev.clojure.org/jira/browse/CLJS-1718

juhoteperi 2016-07-29T17:11:41.000127Z

We could rename the files... but seems like something that should eventually be fixed in Cljs

anmonteiro 2016-07-29T17:12:03.000128Z

Agreed that this should be fixed upstream

anmonteiro 2016-07-29T17:12:12.000129Z

CLJSJS already provides different namespaces, so that should be enough

juhoteperi 2016-07-29T17:12:19.000130Z

But if you want, you can workaround it in Cljsjs for now

anmonteiro 2016-07-29T17:12:44.000131Z

I’ve solved it locally by downloading one of them and putting it directly in :foreign-libs

anmonteiro 2016-07-29T17:13:11.000132Z

@juhoteperi: I’m pretty sure the only solution in CLJSJS would be to name those files differently

anmonteiro 2016-07-29T17:13:18.000133Z

clojure.inc.js would always conflict with each other

juhoteperi 2016-07-29T17:21:42.000134Z

Yes.

juhoteperi 2016-07-29T17:21:55.000135Z

But renaming is possible