Clojurians Log v2

Theres' a bug in react-datepicker externs. Where excludeDates is said to be a function but is in reality array(excludeDates: _react2.default.PropTypes.array,). Before discovering the bug I tried to just update the react-datepicker. But Im struggling, like so often with generating externs. So for this file https://www.refheap.com/122782/raw via http://michaelmclellan.me/javascript-externs-generator/ what name should I extern?

@hlolli can't open your paste

ok, http://www.refheap.com is down seemingly

http://pastebin.com/raw/XmUQ0qgd

@hlolli tried DatePicker?

also looking in the console and just typing Date might yield other options

yes but not Date.

Date works, and returns only extern for the function Date. The last person to create externs for react-datepicker used DatePicker according to react-datepicker.ext.js So I must be doing something wrong.

@hlolli what's the URL you're putting into the generator?

that raw pastebin I posted above. It's the generated js file from the jsx, but when I think about it, its the generated .js from the last cljsjs/react-datepicker. Maybe I run the project with node.js and get the newest .js file.

You will need something that serves the file with a text/javascript content type otherwise it won't be loaded as JS

tried <http://localhost:8440/out/react-datepicker.inc.js> but the same. If it can extern the function Date, it must be able to read it correctly?

Date is a JS constructor, are you sure it's coming from that file?

open the console on the externs generator as well so you see if any issues occur

ok

Tried the node.js app for extern-generator, worked last time for me. I include all dependancies, index is react-onclickoutside. And still wont work.

generate-extern -f react.js, react-dom.js, index.js, moment.js, react-datepicker.inc.js -n DatePicker -o datep.ext.js

/usr/lib/node_modules/externs-generator/bin/extern:261
ma(sd,"exit").call(null,1));null==c&&(console.error("Please specify namespace to extern (e.g. -n jQuery)"),ma(sd,"exit").call(null,1));null==a&&(console.error("Please specify an output file for the extern (e.g. -o jquery-extern.js)"),ma(sd,"exit").call(null,1));for(var b=K(b),e=null,g=0,h=0;;)if(h<g){var k=e.W(null,h);Mf(d,k);h+=1}else if(b=K(b))e=b,Cc(e)?(b=tb(e),h=ub(e),e=b,g=S(b),b=h):(b=M(e),Mf(d,b),b=O(e),e=null,g=0),h=0;else break;d=ma(d,c);if(null==d)throw[B("Namespace '"),B(c),B("' was not found. Make sure the library is loaded and the name is spelled correctly.")].join("");
                                                                                                                                                                                                                                                                                                                     
Namespace 'DatePicker' was not found. Make sure the library is loaded and the name is spelled correctly.

@hlolli maybe open an issue and ping the people that previously created/updated the package

@therabidbanana (if its not inapproproate to ping you here), maybe you can look at the extern to react-datepicker you generated?

@hlolli : looking at the thread now

So are you just trying to update externs for current version?

I was trying that, to see if it solved the extern issue, that the externt wont say that excludeDates is a function, but an array. When using excludeDates on my datepicker component I encounter that error, telling me its not a function.

But I also have another bug unrelated to externs, hoping to see the library developers had fixed it (which is that the calander will disappear without giving onBlur or onFocus function call, but thats unrelated). (thats why Im curious to update react-datepicker to 0.29.0)

Not sure about the node externs-generator, haven't used that - it might not like the funky webpack wrappings from the react-datepicker build. It's entirely possible I missed a step with my notes - I had to try a few times to get the externs generator online to work

Yes I thought so too, that these webpack wrappings are causing the generator not finding the namespace functions. We could write this by hand, not that I know how to do that, but I would love to know how.

The full list of props for the datepicker is only ~25 functions/bools/arrays.

What errors are you seeing with the current externs?

react-datepicker.inc.js:454 Uncaught TypeError: excludeDates.some is not a function

What's the calling code look like that generates that?

Now like this, but its the same with js-obj and/or js-global-array :excludeDates [(js/moment)]

full code call tough

(js/React.createElement
                            js/DatePicker
                            #js {:showYearDropdown true
                                 :dateFormat "YYYY-MM-DD"
                                 :key "service-left"
                                 :id "service-from"
                                 :excludeDates [(js/moment)]
                                 :maxDate (js/moment)
                                 :placeholderText "Date from"
                                 :onChange (fn [t]
                                             (om/update-state! this assoc :service-from t)
                                             (om/update-state! this assoc :service-from-focus? false)
                                             (when (js/moment.isMoment (:service-to (om/get-state this)))
                                               (when (.isAfter t (:service-to (om/get-state this)))
                                                 (om/update-state! this assoc :service-to nil))))
                                 :onBlur #(om/update-state! this assoc :service-from-focus? false)
                                 :onFocus #(om/update-state! this assoc :service-from-focus? true)
                                 :selected (:service-from (om/get-state this))
                                 :title "Service date from"
                                 :fixedHeight true
                                 :isClearable true
                                 :popoverTargetOffset "18px 0"})

Seems like #js isn't working like you expect it to and downgrading the CLJS vector to a real JS array

I'd guess the bug isn't in the externs there

You need to put #js in front of nested objects

(or in your case, arrays)

excludeDates: #js [(js/moment)]

yes, ahhhh, I should have known that.

it works now 😄 so I leave the package update to someone else. Thanks for looking into this!

I think clj->js handles arbitrary nesting, you could try wrapping all your options in that as well.

yes I do it all the time with style. But I was recently using react-material-ui, and all arrays there didnt need the #js tag. But then I remembered that I was using a wrapped lib from madvas.

(If you want to avoid forgetting another #js - it's easy to do, I think I've had the issue a few times)

ok, wow, I thought clj->js was just the exact same of #js, glad to learn that my millions of nested #js tags can be removed. I type #js too often hehe.

I think technically they compile differently (and theoretically #js is more efficient in that case - because it's a macro instead of a function call?), but I haven't looked into the details

ok ok. Well, its enough work today. Now I go home and... yes, do more clojure 😄 so see you around

Hi guys I’m having a hard time making an externs package, I’m using this tool : http://michaelmclellan.me/javascript-externs-generator/ and I’m trying to get an empty object, ( _module ) and it says it can’t find it. The js file is here : https://github.com/TriumphLLC/Blend4Web/blob/master/src/b4w.js I’m not sure I understand how to use this tool.

@mikebelanger what is an empty object?

@juhoteperi ie var _module = {};

But that is inside a closure: var b4w = ((typeof b4w === "object") ? b4w : (function(exports) {

@juhoteperi oh so I should try and grab the b4w object instead?

Yes

@juhoteperi ok it’s saying it can’t find the b4w. All I entered is ‘b4w’, do I have to enter one of the object’s values?

hmh, should work

It looks the b4w.js file has some namespace declarations above that, would that interfere with it?

I don't think it should be reading those JSDocs

what url are you using for the generator?

@juhoteperi http://michaelmclellan.me/javascript-externs-generator/

for the JS file

https://github.com/TriumphLLC/Blend4Web/blob/master/src/b4w.js ..mind you this is under the git blob, maybe that’s the problem

yes, it can load a html file

check browser console for errors

If it is hard to find proper copy available at http server, you can download the file to local disk and use this npm tool: https://github.com/jmmk/javascript-externs-generator (npm install -g externs-generator)

(In fact that is the same generator but as a npm package)

Are you sure it can handle html? The console is complaining about the ‘<!DOCTYPE html>’ right at the beginning

ah sorry, typo 😄

I meant to say, it can't load a html file

@juhoteperi it’s saying "SyntaxError: expected expression, got ‘<'"

Oh, sorry just read your last message 😛

@juhoteperi cool it works when I goto original git path, thanks!