Clojurians Log v2

@juhoteperi if I just merge this will it be deployed etc? https://github.com/cljsjs/cljsjs.github.io/pull/14

hmm not sure, maybe not

IIRC only data.json is automatically updated

so which of the glorious scripts in there is it that I need to run? 😛

seems to be deploy-update.sh?

deploy-update.sh only updates data.json

build.sh updates everything

update.sh generates new data.json

hah, ok, so I have no idea what that script did, not seeing any commits but it did deploy the site

http://cljsjs.github.io/

Cool!

The header text could use another font?

-apple-system,BlinkMacSystemFont,avenir next,avenir,helvetica,helvetica neue,ubuntu,roboto,noto,segoe ui,arial,sans-serif

oh right

I not fan of trying to use "native fonts"

I have no idea what the site looks to you

search highlight doesn't work currently?

show me what it looks like for you

just missing .highlight class

could be worse

I gotta run right now but will be back in a bit

and the highlight could be used with dependency vector also

yeah, I think I accidentally removed that

I actually got tripped up the other day trying to use a cjsjs package because I didn’t realize there were README's on github 😛 So I like the new UI additions.

For what it’s worth, I like the consolas font too

hey guys I just wanted to add an example to cljsjs/three’s README.md. The guidelines for a PR kind of imply this isn’t PR-worthy. Is there another way I can modify the README?

PR is fine

@martinklepsch did you check what instructions show for Closure libs? there are a few

oh right

did not account for that

I just fixed the highlighting stuff btw

We could parse the deps.cljs and use that to check the usage instructions

Usage instructions could note if the library provides multiple namespaces

and if it provides Closure lib (`:libs` -> "This is a Closure library")

Multiple provided ns -> "cljsjs.airbrake and x additional namespaces"

First one is probably always the "main" ns

and once it is parsed, we could pretty-print it when we show it,

we could also add filter foreign-dep / closure lib!

do you want to implement these or should I?

(btw. argh, why is Slack using 100% cpu)

"Package types: Foreign dep, Closure lib, CommonJS/AMD/ES6 (forthcoming)"

I wont be able to spend more time on this today but maybe tomorrow again

Ok, everything will be read tomorrow 😄

how do you mean read tomorrow?

Reason I dropped the custom font btw: it felt like a custom font doesn't add much value.

I'm fine with doing something that's not system as long as it's nothing that needs to be downloaded extra, that makes sense?

ready*

@martinklepsch: not sure if the link alignment is what was intended

That's as I intended it — what would you suggest alternatively?

Nvm then, I was thinking maybe justifying the alignment or spacing it so text aligned vertically with the row above it, but if it's just flowing to the next line its not anything really worth focusing on

given that it's 4 you could split them into columns but I just wanted something flexible that could accomodate changing needs 🙂 @flyboarder

@martinklepsch: just used the site on desktop for the first time, very nice!Much useful changes

@flyboarder cool glad you like it! I'll use that moment to also thank you for your contributions to this project 👏 🙂

😊 the clojure community has created many great tools, im just glad I can give back

Also you solved the one thing im constantly doing on the site, and thats searching it (no more cmd+F) 👏

@juhoteperi what do you think about changing the usage snippet to

(ns your.namespace
  (:require [cljsjs.airbrake]))

seems fine

@flyboarder I myself will probably still use cmd-f lol

I think the dots + lack of brackets might be confusing that's why I'm asking

could be wrong ¯\(ツ)/¯

¯\(ツ)/¯

@juhoteperi so how much did you dislike using tachyons? 😄

I guess users will understand that they shouldn't remove their existing requires

@martinklepsch I wouldn't choose to use it myself 😄

we already have a small lag when switching the filters; challenge achieved 😄

it's just the dom operations

no lag between all - foreign libs, but lag closure libs -> all/foreign libs as it needs to create ~300 list items

yep

I know it's the DOM ops I'm just joking, I guess it's a good problem to have 😛

https://github.com/bvaughn/react-virtualized

WE HAVE SO MANY LIBRARIES WE NEED TO OPTIMIZE!!111!1

this is one lib I wouldn't probably rewrite on Cljs

Not that I have yet used it on Cljs

looks pretty cool 👍

I should probably try it with my autocomplete lib as I've been having problems with cases where it needs to list ~500 results

made a few changes to the nav/deps.cljs rendering, nothing exciting https://cljsjs.github.io/

easier to read and more noticeable now

Cool. I was sure there must be some classes for something like that 😄

"Show Usage Instructions" text could stay the same when toggled? Likke "Usage instructions v" ""Usage instructions ^"

currently, as the width changes, it will in some cases jump between toggles

like with async

@juhoteperi ah yeah, interesting

Guess we can make it Usage Instructions and then >>|x

maybe proper css caret?

// Dropdown arrow/caret
.caret {
  display: inline-block;
  width: 0;
  height: 0;
  margin-left: 2px;
  vertical-align: middle;
  border-top:   @caret-width-base dashed;
  border-top:   @caret-width-base solid ~"\9"; // IE8
  border-right: @caret-width-base solid transparent;
  border-left:  @caret-width-base solid transparent;
}

and border-top: 0; border-bottom: @caret-width-base dashed; for reversed caret

Hmh, currently links and code have the same color and links don't even have any hover effect

hover -> underline would be good at least