Clojurians Log v2

@mikebelanger http://www.tonejs.org did not work for me but http://tonejs.org did — maybe that www isn't set up to work?

@martinklepsch oh neat, I didn't realize that. I made a PR where the url was changed to point directly to github repo, but http://tonejs.org is much easier -- plus they're probably going to make a non-github homepage eventually for that.

@martinklepsch just updated PR to include http://tonejs.org url

@mikebelanger There is a conflict in the PR, the version number in readme is already fixed (they are automatically updated)

@juhoteperi oh ok, what should I do, just delete my PR?

Other changes are still fine

I fixed the conflict

@juhoteperi ah cool, thanks. If that happens again, should I just merge like you just did?

Merge is okay

Rebase is even better

Or just commit --amend & force push in case of a single commit

ok, thanks I'll have to remember that for next time. It doesn't look like the site link works, does it just take time to reflect the changes http://cljsjs.github.io?

@mikebelanger might take a few mins, think the site is updated using a cron job

Do you guys know of any cljsjs packages that use multiple levels of Google Closure compilation? ie) advanced, whitespace, simple?

oh, found one, please disregard last question

If you have multiple .ext.js files for your project, and they're all in the common subdir in the fileset, will Google Closure incorporate all of them during its compilation (provided its advanced?)

Closure doesn't care about extension or path

ClojureScript compiler reads the deps.cljs files and builds options for Closure from those

Cljsjs tooling usually creates the deps.cljs file

https://github.com/clojure/clojurescript/wiki/Packaging-Foreign-Dependencies

@juhoteperi ah I see thanks

So in cljsjs packaging instructions, it asks users to compile things with the :advanced flag. It looks like my projects work on anything *but* :advanced, and I suspect it's something to do with my externs. But it works fine on whitespace and simple, is it still acceptable to be on cljsjs?