cljsjs

anmonteiro 2017-01-24T18:12:32.000720Z

@juhoteperi the deps.cljs file for clipboard.js doesn't have a :file-min entry

anmonteiro 2017-01-24T18:12:44.000721Z

this is causing our production build to include a non-minified version of clipboard

anmonteiro 2017-01-24T18:13:05.000722Z

(the minified file is in the JAR, just not referenced from deps.cljs)

anmonteiro 2017-01-24T18:13:12.000723Z

has this happened to you before?

anmonteiro 2017-01-24T18:14:39.000724Z

oh, this should probably be production https://github.com/cljsjs/packages/blob/master/clipboard/build.boot#L25

martinklepsch 2017-01-24T18:15:46.000726Z

@anmonteiro important bit is the file extension

anmonteiro 2017-01-24T18:16:08.000728Z

there was a .min.js

anmonteiro 2017-01-24T18:16:22.000729Z

it was put in a development folder instead of a production folder

martinklepsch 2017-01-24T18:16:28.000730Z

should be inc.min.js or min.inc.js (not sure which right now)

anmonteiro 2017-01-24T18:16:31.000731Z

would this fix it? https://github.com/cljsjs/packages/pull/952/files

anmonteiro 2017-01-24T18:16:42.000733Z

oh. it's the extension, got it

martinklepsch 2017-01-24T18:16:44.000734Z

@anmonteiro does it show up in deps.cljs with your change?

anmonteiro 2017-01-24T18:16:55.000735Z

I edited in GitHub because I'm lazy 😄

anmonteiro 2017-01-24T18:17:00.000736Z

going to properly clone the repo

martinklepsch 2017-01-24T18:17:06.000737Z

😄

martinklepsch 2017-01-24T18:17:09.000738Z

good luck

martinklepsch 2017-01-24T18:17:19.000740Z

gotta sleep 👋

anmonteiro 2017-01-24T18:17:26.000741Z

thanks

juhoteperi 2017-01-24T18:18:43.000742Z

.min.inc.js is the correct extension

juhoteperi 2017-01-24T18:18:54.000743Z

btw, if you need to just copy text to clipboard: https://github.com/metosin/komponentit/blob/master/src/cljs/komponentit/clipboard.cljs

anmonteiro 2017-01-24T18:21:10.000745Z

@juhoteperi thanks. I'm working on a proper PR locally now, closing that one

anmonteiro 2017-01-24T18:26:03.000748Z

@juhoteperi https://github.com/cljsjs/packages/pull/953

anmonteiro 2017-01-24T18:27:11.000752Z

👍