Clojurians Log v2
Clojure programming
Channels
Apps
cljsjs
pupeno 2017-01-29T00:04:50.000840Z
Ah… when classnames.inc.js is loaded, it doesn’t define window.classNames. Instead it defines module.exports.
flyboarder 2017-01-29T02:05:03.000841Z
@juhoteperi: with the new closure compiler what does this mean for our existing cljsjs packages, how do we upgrade?
martinklepsch 2017-01-29T03:56:54.000842Z
@flyboarder: I don't think there will be a one-size-fits-all type solution. Currently thinking that maybe we investigate how to package react and maybe 1-2 other popular ones and provide these with a -closure modifier
martinklepsch 2017-01-29T03:57:12.000843Z
@flyboarder: still lots to figure out (for me at least)
flyboarder 2017-01-29T04:29:56.000844Z
Yeah I just want to make sure I'm going in the right direction
martinklepsch 2017-01-29T05:07:56.000845Z
I think old approach is still valid for now. Will take a couple of weeks until someone figured out the consequences of all the new stuff
martinklepsch 2017-01-29T05:09:46.000846Z
I think old approach is still valid for now. Will take a couple of weeks until someone figured out the consequences of all the new stuff
emccue 2017-01-29T05:35:13.000847Z
I want to package react-google-login, is there a sort of "absolute beginners guide to cljsjs packaging" that I could reference?
martinklepsch 2017-01-29T07:51:09.000849Z
@emccue here you go: https://github.com/cljsjs/packages/wiki/Creating-Packages
pupeno 2017-01-29T11:34:12.000851Z
Should I make cljsjs packages for all npm dependencies of the lib I'm re-packaging?