Clojurians Log v2

Hmm, I wanted to package this small library for cljsjs but it doesn't seem to have any external functions. It just mutates another library upon import. https://github.com/bbecquet/Leaflet.RotatedMarker/blob/master/leaflet.rotatedMarker.js

What do I do about that?

I still want the module loading code to not be killed by the google closure compiler.

@rovanion https://github.com/cljsjs/packages/tree/master/leaflet-fullscreen

@juhoteperi That's a weird externs file since the js itself never defines a var leafletFullscreen.

Doesn't matter, only the "leaf names" matter

i.e. foo.bar.fullscreenControl, foo.fullscreenControl and var fullscreenControl in extern work the same

Or maybe more specifically, any names in externs, no matter where it is, are kept, so foo.bar.fullscreenControl will cause Closure to keep names foo, bar and fullscreenControl always

Closure doesn't care about the structure

hey guys, can someone help me to get the package out? I need to get this to work: https://github.com/cljsjs/packages/pull/1356

@ag for global-exports part: https://github.com/cljsjs/packages/blob/master/react-transition-group/build.boot#L29

don't know about the other question

@juhoteperi what's the best way to publish the package (even before PR gets accepted?)

can I run deploy-changed.sh even before the PR gets accepted?

boot package install will install it locally

@ag Is the PR ready? I can accept it if you think it works

a) I need it to run it in CI - have to push it somewhere, somehow b) I'd like to update readme and add an example of a test c) I'd like to get the global-exports part in

^ @juhoteperi

merging the PR is only way to get it pushed to cljsjs clojars group

you could modify group name and run boot package deploy yourself

or, I can just merge it, readme can be updated after it is merged

global-exports is not that important currently, you can add it later

give me sometime, I'll ping you then, Thanks a lot!